Skip to content

Re-enable fused matmul rules #2370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged

Re-enable fused matmul rules #2370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions onnxscript/rewriter/ort_fusions/_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import onnxscript.ir as ir
import onnxscript.ir.passes.common as common_passes
import onnxscript.rewriter.ort_fusions.fused_matmul_rule_sets as fused_matmul_rule_sets
import onnxscript.rewriter.ort_fusions.shape_optimization as shape_optimization
from onnxscript.optimizer import optimize
from onnxscript.rewriter import rewrite
Expand Down Expand Up @@ -37,9 +38,7 @@
*instance_to_group_normalization.rules.rules,
# NOTE: group normalization merge silu should be applied after instance to group normalization
# *group_normalization_merge_silu.rules.rules,
# NOTE: The rules below are broken:
# https://github.com/microsoft/onnxscript/pull/2317#issuecomment-2896058483
# *fused_matmul_rule_sets.fused_matmul_rule_sets(),
*fused_matmul_rule_sets.fused_matmul_rule_sets().rules,
]


Expand Down
5 changes: 2 additions & 3 deletions onnxscript/rewriter/ort_fusions/fused_matmul_rule_sets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,9 +327,8 @@ def pattern(self, op, x, y):


def fused_matmul_rule_sets() -> orp.RewriteRuleSet:
"""Returns a set of rules introducing onnxruntime contrib obs.
This requires onnxruntime to run the model after
it is rewritten.
"""Returns a set of rules introducing onnxruntime contrib ops.
This requires onnxruntime to run the model after it is rewritten.

Returns:
RewriteRuleSet
Expand Down
Loading