Skip to content

feat(atenlib): ops 7/n #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jan 7, 2023
Merged

feat(atenlib): ops 7/n #279

merged 14 commits into from
Jan 7, 2023

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Jan 5, 2023

upsample_nearest2d, amax, amin and adaptive pools

upsample_nearest2d was tested locally on opset17. Opset18 cannot be tested yet because onnx runtime does not support it yet.

@justinchuby justinchuby mentioned this pull request Jan 5, 2023
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #279 (dd375c7) into main (677ca1f) will increase coverage by 0.23%.
The diff coverage is 88.00%.

@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
+ Coverage   72.73%   72.97%   +0.23%     
==========================================
  Files          95       95              
  Lines        9063     9113      +50     
==========================================
+ Hits         6592     6650      +58     
+ Misses       2471     2463       -8     
Impacted Files Coverage Δ
onnxscript/function_libs/torch_aten/ops/nn.py 56.46% <80.00%> (+2.73%) ⬆️
...t/function_libs/torch_aten/ops_correctness_test.py 93.70% <92.10%> (-0.26%) ⬇️
onnxscript/function_libs/torch_aten/ops/core.py 58.50% <100.00%> (+0.27%) ⬆️
onnxscript/onnx_opset/_impl/opset18.py 40.00% <0.00%> (+8.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@justinchuby justinchuby mentioned this pull request Jan 5, 2023
14 tasks
@justinchuby justinchuby added the module: torchlib Related to the torch/aten function lib in development label Jan 6, 2023
@justinchuby justinchuby marked this pull request as ready for review January 6, 2023 20:04
@justinchuby justinchuby changed the title feat(atenlib): upsample_nearest2d feat(atenlib): ops 7/n Jan 6, 2023
@justinchuby justinchuby merged commit 47fe75f into main Jan 7, 2023
@justinchuby justinchuby deleted the justinchu/ops-6 branch January 7, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: torchlib Related to the torch/aten function lib in development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants