Skip to content

fix(atenlib): GE and LE op #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2023
Merged

fix(atenlib): GE and LE op #325

merged 2 commits into from
Jan 18, 2023

Conversation

xiaowuhu
Copy link
Contributor

@xiaowuhu xiaowuhu commented Jan 17, 2023

previous implementation is greater not greater and equal. fixes #315

@xiaowuhu xiaowuhu mentioned this pull request Jan 17, 2023
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #325 (76b336f) into main (9439e10) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #325   +/-   ##
=======================================
  Coverage   73.17%   73.17%           
=======================================
  Files          96       96           
  Lines        9476     9476           
=======================================
  Hits         6934     6934           
  Misses       2542     2542           
Impacted Files Coverage Δ
onnxscript/function_libs/torch_aten/ops/core.py 63.15% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@justinchuby justinchuby changed the title fix GE and LE op fix(atenlib): GE and LE op Jan 17, 2023
@justinchuby justinchuby added the module: torchlib Related to the torch/aten function lib in development label Jan 17, 2023
@xiaowuhu xiaowuhu merged commit be4ea50 into microsoft:main Jan 18, 2023
@xiaowuhu xiaowuhu deleted the xiaowu/fixGeLeOp branch January 18, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: torchlib Related to the torch/aten function lib in development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ge, le
2 participants