Skip to content

fix(atenlib): combine cross_entropy_loss #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 27, 2023
Merged

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Mar 24, 2023

  • Fix static optional support in ParamSchema
  • Make cross_entropy_loss a script function

Follow up of https://github.com/microsoft/onnx-script/pull/444/files#diff-647f5c6f5a51c850e0a6bfd534cc8d1357d5b617c432693af121830b65a324c2R242

@justinchuby justinchuby requested a review from xiaowuhu March 24, 2023 18:00
@justinchuby justinchuby added the merge at lgtm Reviewers can merge when they approve label Mar 24, 2023
@justinchuby justinchuby requested a review from gramalingam March 24, 2023 18:01
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #555 (b1b7e0b) into main (9fe15b2) will increase coverage by 0.01%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
+ Coverage   73.91%   73.92%   +0.01%     
==========================================
  Files         109      109              
  Lines       11007    11004       -3     
  Branches     1142     1142              
==========================================
- Hits         8136     8135       -1     
+ Misses       2564     2561       -3     
- Partials      307      308       +1     
Impacted Files Coverage Δ
...s/function_libs/torch_aten/ops_correctness_test.py 90.27% <ø> (ø)
onnxscript/function_libs/torch_aten/ops/nn.py 66.57% <33.33%> (+0.52%) ⬆️
onnxscript/values.py 91.70% <50.00%> (-0.93%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-advanced-security
Copy link

You have successfully added a new lintrunner configuration lintrunner. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@justinchuby justinchuby added the module: torchlib Related to the torch/aten function lib in development label Mar 24, 2023
@justinchuby justinchuby merged commit cf3288b into main Mar 27, 2023
@justinchuby justinchuby deleted the justinchu/cross-entropy branch March 27, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge at lgtm Reviewers can merge when they approve module: torchlib Related to the torch/aten function lib in development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants