Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Tokenize/parse fstring interpolations #223

Closed
jakebailey opened this issue Oct 10, 2018 · 0 comments
Closed

Tokenize/parse fstring interpolations #223

jakebailey opened this issue Oct 10, 2018 · 0 comments
Assignees
@jakebailey
Labels
feature: intellisense

Comments

@jakebailey
Copy link
Member

Using the scanned items from #222, tokenize each interpolation and produce an AST.

Example of tokenizing/parsing a string: https://github.com/Microsoft/python-language-server/blob/master/src/Analysis/Engine/Impl/ExpressionFinder.cs

Parsing needs to start at the expression level (https://docs.python.org/3/reference/lexical_analysis.html#f-strings), so likely also needs to call a function similar to ParseExprStmt which disallows things like assignment.

Epic #6.
@jakebailey jakebailey self-assigned this Oct 10, 2018
@qubitron qubitron removed the enhancement New feature or request label Oct 10, 2018
@brianbok brianbok mentioned this issue Mar 18, 2019
Merged
brianbok added a commit that referenced this issue Mar 18, 2019
@brianbok
Parsing f-strings (#685)
9c585e4 
f-strings were treated as normal strings before. Now we parse their content, including f-string expressions inside.
We provide completion and hovering for sub-expressions.
Closes #221.
Closes #222.
Closes #223.
Closes #224.
Closes #6.
jakebailey pushed a commit to jakebailey/python-language-server that referenced this issue Nov 1, 2019
@brianbok
Parsing f-strings (microsoft#685)
952668a 
f-strings were treated as normal strings before. Now we parse their content, including f-string expressions inside.
We provide completion and hovering for sub-expressions.
Closes microsoft#221.
Closes microsoft#222.
Closes microsoft#223.
Closes microsoft#224.
Closes microsoft#6.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jakebailey jakebailey

Labels
feature: intellisense
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakebailey @qubitron