This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Parsing f-strings #685
Merged
Parsing f-strings #685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're also going to need a fix similar to #752 to prevent completion from happening in the literal part of the fstring, i.e., not have this:
|
jakebailey
reviewed
Mar 18, 2019
jakebailey
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
f-strings were treated as normal strings before. Now we parse their content, including f-string expressions inside. We provide completion and hovering for sub-expressions. Closes microsoft#221. Closes microsoft#222. Closes microsoft#223. Closes microsoft#224. Closes microsoft#6.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f-strings were treated as normal strings before. Now we parse their content, including f-string expressions inside.
We provide completion and hovering for sub-expressions.
Closes #221.
Closes #222.
Closes #223.
Closes #224.
Closes #6.