This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Added an option to propagate parameter types to base methods#283
Merged
MikhailArkhipov merged 1 commit intomicrosoft:masterfrom Oct 25, 2018
Conversation
| /// <c>True</c> to propagate parameter types to base methods. | ||
| /// Parameter types always propagate to derived methods. | ||
| /// </summary> | ||
| public bool PropagateParameterTypeToBaseMethods { get; set; } |
There was a problem hiding this comment.
Is there case when we don't want this?
Contributor
Author
There was a problem hiding this comment.
In A: B, B: C case, when we see b:B = ..., b.foo(SomeType()), b can be either of A and B. So, assuming substitution principle, B.foo should propagate to A.foo. However, there's no principle, that would tell, that C.foo should also take an instance of SomeType. At best, its an lucky guess.
So I think its good to have an option.
Now for my purposes, I need it true. But you guys can decide for the default value.
There was a problem hiding this comment.
I mean, it is not something that user sets so it it typically set by the application one way or another. #261 may be related.
MikhailArkhipov
approved these changes
Oct 25, 2018
jakebailey
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
…eterTypePropagationToBase Added an option to propagate parameter types to base methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is similar #194, in that the same types parameter types might be OK for base methods. It could happen when we just don't have any examples in the current code, that would give that kind of information to analyzer.
By default set to
falseto keep conservative behavior.