This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Wire up events from RDT to module resolution #703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
March 1, 2019 09:51
MikhailArkhipov
changed the title
src/Analysis/Core/Impl/DependencyResolution/PathResolverSnapshot.cs
Outdated
Show resolved
Hide resolved
jakebailey
reviewed
Mar 12, 2019
jakebailey
reviewed
Mar 12, 2019
| _disposableBag.ThrowIfDisposed(); | ||
| // TODO: handle? | ||
| switch (c.type) { | ||
| case FileChangeType.Deleted: |
There was a problem hiding this comment.
Do you know if this case gets hit?
b and food still seem to exist after I make b with def foo(): return 123, import it in a, then delete b, but I could be testing something different than what this handles.
There was a problem hiding this comment.
Frankly, I haven't seen it hit. I don't know when VSC sends it, this is why we have manual library watcher. But it doesn't hurt to handle.
There was a problem hiding this comment.
We could start watching workspace manually too, but that's a different issue.
| @@ -65,12 +66,14 @@ private class DocumentEntry { | |||
| lock (_lock) { | |||
| entry = FindDocument(null, uri); | |||
| if (entry == null) { | |||
| var resolver = _services.GetService<IPythonInterpreter>()?.ModuleResolution?.CurrentPathResolver; | |||
There was a problem hiding this comment.
What is the case when _services.GetService<IPythonInterpreter>() or ModuleResolution is null?
AlexanderSher
approved these changes
Mar 14, 2019
jakebailey
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
* Fix microsoft#668 (partial) * Tests * Revert "Tests" This reverts commit 7ffc9db. * Basic event wire up * Add test * Test * Formatting * Fix search paths mess * Handle deleted files better * PR feedback * MErge issues * Fix race condition at builtins load * PR feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #700