Add support for osx-arm64 #756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
=======================================
Coverage 70.13% 70.13%
=======================================
Files 277 277
Lines 8651 8651
Branches 1006 1006
=======================================
Hits 6067 6067
Misses 2065 2065
Partials 519 519 ☔ View full report in Codecov by Sentry. |
jalkire
approved these changes
Oct 16, 2024
Contributor
jalkire
left a comment
jalkire
left a comment
There was a problem hiding this comment.
Is there any kind of signing that should occur for Mac?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to produce an
osx-arm64version of the tool. It also includes a small doc change about building locally--local builds of arm-64 should not be treated as official since we will be publishing this as a separate package.