Specify correct image for running on osx-arm64 #913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run |
Contributor
Author
|
/azp run |
Contributor
Author
|
/azp run |
sfoslund
approved these changes
Jan 31, 2025
Contributor
Author
|
/azp run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As called out in #912, we're not currently running our CI or PR builds on osx-arm64. This was a typo in #756 for the CI build, and that got repeated for the PR build in #875. This PR corrects the image to use
macos-14-arm64for both the CI and PR builds, which is the image that we use in our internal validation pipeline. This image is an internal-only resource, but it leverages the runner configuration described at https://github.com/actions/runner-images/blob/macos-14-arm64/20250127.794/images/macos/macos-14-arm64-Readme.md.