Skip to content

typo: ThrowArguement -> ThrowArgument; fix SPDX URL anchor #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaveTryon merged 4 commits into from
Oct 31, 2024
Merged

typo: ThrowArguement -> ThrowArgument; fix SPDX URL anchor #769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f6263d4
typo: ThrowArguement -> ThrowArgument
bact Oct 31, 2024
b1e1625
Bring back anchors to specific section in a web page
bact Oct 31, 2024
3bd67e7
Merge branch 'main' into typo-ThrowArguement
bact Oct 31, 2024
5868f12
Merge branch 'main' into typo-ThrowArguement
DaveTryon Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.Sbom.Parsers.Spdx22SbomParser/Entities/Enums/SPDXRelationshipType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace Microsoft.Sbom.Parsers.Spdx22SbomParser.Entities.Enums;
/// Defines the type of <see cref="SPDXRelationship"/> between the source and the
/// target element.
///
/// Full definition here: https://spdx.github.io/spdx-spec/v2.2.2/relationships-between-SPDX-elements/.
/// Full definition here: https://spdx.github.io/spdx-spec/v2.2.2/relationships-between-SPDX-elements/#111-relationship-field.
/// </summary>
[JsonConverter(typeof(JsonStringEnumConverter))]
public enum SPDXRelationshipType
Expand Down
2 changes: 1 addition & 1 deletion ...crosoft.Sbom.Parsers.Spdx22SbomParser/Utils/InternalMetadataProviderIdentityExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public static string GetPackageName(this IInternalMetadataProvider internalMetad
/// <summary>
/// Generates the package verification code for a given package using the SPDX 2.2 specification.
///
/// Algorithm defined here https://spdx.github.io/spdx-spec/v2.2.2/package-information/.
/// Algorithm defined here https://spdx.github.io/spdx-spec/v2.2.2/package-information/#79-package-verification-code-field.
/// </summary>
/// <param name="internalMetadataProvider"></param>
/// <returns></returns>
Expand Down
6 changes: 3 additions & 3 deletions test/Microsoft.Sbom.Api.Tests/ApiConfigurationBuilderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,21 +175,21 @@ public void GetConfiguration_DefaultRuntime()
[DataRow(" ")]
[DataRow(null)]
[ExpectedException(typeof(ArgumentException))]
public void ThrowArguementExceptionOnRootPathValues(string input)
public void ThrowArgumentExceptionOnRootPathValues(string input)
{
ApiConfigurationBuilder.GetConfiguration(input, null, null, null, null);
}

[TestMethod]
[ExpectedException(typeof(ArgumentNullException))]
public void ThrowArguementNulExceptionOnNullMetadata()
public void ThrowArgumentNulExceptionOnNullMetadata()
{
ApiConfigurationBuilder.GetConfiguration("random", null, null, null, null);
}

[TestMethod]
[ExpectedException(typeof(ArgumentException))]
public void ThrowArguementExceptionOnSpecificationZero()
public void ThrowArgumentExceptionOnSpecificationZero()
{
ApiConfigurationBuilder.GetConfiguration("random", null, null, null, metadata, new List<SbomSpecification>(), runtime);
}
Expand Down