-
Notifications
You must be signed in to change notification settings - Fork 79
Publish a new release supporting php 8.2 syntax? #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@roblourens could you take a look? Also, thoughts on whether this should be 0.2.0 or 0.1.2? Applications should be largely unaffected if they parse the same valid snippets they did in the past, so 0.1.2 probably makes sense This adds a brand new type for (applications using this library to parse out union types shouldn't be affected as long as they don't start using dnf types) Aside: This would be less of an issue once there was a 1.x release, where new features could be minor releases |
@roblourens fyi - I think the latest |
@roblourens - pinging again about publishing a release since it's easy to lose track of notifications on the weekend. PHP 8.2.0RC2 is out https://www.php.net/ - https://wiki.php.net/todo/php82 will be out in November |
I got to this last - everything I merged should be fine to go out in a 0.1.2 right? |
Yes - everything merged is fine to go out in a 0.1.2 release
|
I realized one thing - the way HaltCompilerStatement is parsed could use some work for easily inferring If a release is created before that I can just keep the property name of |
But other than #389, there were no issues with extracting the needed information from new parsed nodes (e.g. exact same computed offset for AST_HALT_COMPILER) when I started using tolerant-php-parser |
@roblourens #389 continues to be the only PR with fixes I'd want before creating a release with the other changes - could you review that?
|
#391 should also be included to fix a regression |
Done |
See
#370 #374 #375and #382 , in addition to changes that were already merged to support php 8.2 syntax or other improvementsThe text was updated successfully, but these errors were encountered: