Skip to content

Set up github workflows for multiple php versions #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

TysonAndre
Copy link
Contributor

@TysonAndre TysonAndre commented Aug 11, 2022

Run this alongside Travis CI

  • Start testing this with php 8.2, the feature freeze was in July with the first beta https://wiki.php.net/todo/php82
  • php betas are often late for getting stable tags in travis - https://docs.travis-ci.com/user/languages/php/#php-versions does not have images for the php 8.2 nightly (the master and nightly tags will eventually point to 8.3 and there might not be an 8.2 for a while after that)
  • Start with just phpunit tests for now, to make this easier to review
  • This will give faster feedback if there are travis queueing delays, and show results for individual php versions separately
  • Running dockerfiles makes it easier to develop/run the same checks locally (if there is a build failure) or to customize this (e.g. dependency versions) later

See TysonAndre#2 for results

Note that for this to run in this repo, github workflows must first be enabled by the maintainers (e.g. by merging this or by starting the process of setting up github actions)

Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks. I'd be happy to leave Travis entirely. Could you just add .sh file extensions to the script files?

@TysonAndre
Copy link
Contributor Author

This looks great, thanks. I'd be happy to leave Travis entirely. Could you just add .sh file extensions to the script files?

I added the .sh extensions, this can be extended once checks are merged and running

@roblourens roblourens merged commit 1261275 into microsoft:main Aug 23, 2022
@TysonAndre TysonAndre deleted the test-8.1 branch September 21, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants