Support __halt_compiler statement
#382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://www.php.net/manual/en/function.halt-compiler.php can be used to embed data in php scripts from the outermost scope. In inner scope, it is parsed in php-src only for the sake of error messages about it needing to be in the outermost scope, so treat it as an unexpected token in other contexts. (In an inner `{...}` scope, the call to `token_get_all()` will still stop after `__halt_compiler();`, returning T_INLINE_HTML, so the remaining statements can't be parsed, anyway) Additionally, `__halt_compiler` can't be used as a name, a member name (e.g. method name), etc, so calling it `TokenKind::Name` seems incorrect. (`__COMPILER_HALT_OFFSET__` is already properly a Name) Closes microsoft#381
TysonAndre
force-pushed
the
halt-compiler-support
branch
from
9e352b2 to
a036846
Compare
|
@roblourens - this is ready for review |
|
@roblourens - thoughts? |
roblourens
approved these changes
Sep 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.php.net/manual/en/function.halt-compiler.php can be used to
embed data in php scripts from the outermost scope.
In inner scope, it is parsed in php-src only for the sake of error
messages about it needing to be in the outermost scope, so treat it as
an unexpected token in other contexts.
(In an inner
{...}scope, the call totoken_get_all()will stillstop after
__halt_compiler();, returning T_INLINE_HTML,so the remaining statements can't be parsed, anyway)
Additionally,
__halt_compilercan't be used as a name, a member name(e.g. method name), etc, so calling it
TokenKind::Nameseemsincorrect. (
__COMPILER_HALT_OFFSET__is already properly a Name)Closes #381