Speed up running the framework validation test suite #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. We're parsing thousands of files and there are many tokens per file. The overhead of all the assert statements is noticeable. Optimizing out the check speeds this up 3x from 90 seconds to 30 seconds. 2. Don't write files only to unlink them later. Instead, save the failed file only on test suite failure
|
@roblourens - thoughts? The speedup for this would be convenient for local development, and #382 would make the validation test suite pass so that it can be required in CI again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overhead of all the assert statements is noticeable.
Optimizing out the check (when they'd pass) speeds this up 3x from 90 seconds to 30 seconds - notably, function calls in php are slow, and phpunit has multiple levels of them
Instead, save the failed file only on test suite failure