Skip to content

Use the value of MOCHA_CI_REPORTFILE to instigate JUnit report file production during test runs, don't just check for existance. #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
d3r3kk opened this issue Jun 8, 2018 · 0 comments · Fixed by #1912
Closed

Use the value of MOCHA_CI_REPORTFILE to instigate JUnit report file production during test runs, don't just check for existance. #1911

d3r3kk opened this issue Jun 8, 2018 · 0 comments · Fixed by #1912
Assignees
@d3r3kk
Labels
area-testing debt Covers everything internal: CI, testing, refactoring of the codebase, etc. release-plan
Milestone
June 2018

Comments

@d3r3kk
Copy link

d3r3kk commented Jun 8, 2018

JUnit log file production (from #1897) was added, but the test to use JUnit logs instead of console output is based on the existence of the environment variable MOCHA_CI_REPORTFILE rather than its value.

This is a problem as VSTS allows you to set the value of a variable at queue time, but doesn't allow you to remove the existence of a variable.

Make it possible to run a build without producing JUnit log files at queue time.
@d3r3kk d3r3kk self-assigned this Jun 8, 2018
@d3r3kk d3r3kk added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-testing release-plan labels Jun 8, 2018
@d3r3kk d3r3kk added this to the June 2018 milestone Jun 8, 2018
d3r3kk added a commit to d3r3kk/vscode-python that referenced this issue Jun 8, 2018
@d3r3kk
Test existance *and* value of MOCHA_REPORTER_JUNIT during test runs
4d39a8a 
- allow junit reporting to be disabled at build queue time
- Resolves issue microsoft#1911
@d3r3kk d3r3kk mentioned this issue Jun 8, 2018
Merged
4 tasks
d3r3kk added a commit that referenced this issue Jun 8, 2018
@d3r3kk
Test existance and value of MOCHA_REPORTER_JUNIT during test runs (#…
8009805 
…1912)

Resolves issue #1911
@d3r3kk d3r3kk mentioned this issue Jun 8, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jul 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@d3r3kk d3r3kk

Labels
area-testing debt Covers everything internal: CI, testing, refactoring of the codebase, etc. release-plan
Projects
None yet
Milestone
June 2018
Development

Successfully merging a pull request may close this issue.

Test existance and value of MOCHA_REPORTER_JUNIT during test runs d3r3kk/vscode-python
1 participant
@d3r3kk