Skip to content

Test existance and value of MOCHA_REPORTER_JUNIT during test runs #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 8, 2018
Merged

Test existance and value of MOCHA_REPORTER_JUNIT during test runs #1912

merged 2 commits into from
Jun 8, 2018

Conversation

d3r3kk
Copy link

@d3r3kk d3r3kk commented Jun 8, 2018 •
edited
Loading

Allow junit reporting to be disabled at build queue time.

Fixes #1911

This pull request:

  • Has a title summarizes what is changing
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@d3r3kk
Test existance *and* value of MOCHA_REPORTER_JUNIT during test runs
4d39a8a 
- allow junit reporting to be disabled at build queue time
- Resolves issue microsoft#1911
@d3r3kk d3r3kk self-assigned this Jun 8, 2018
@d3r3kk d3r3kk requested a review from DonJayamanne June 8, 2018 16:00
@codecov
Copy link

codecov bot commented Jun 8, 2018 •
edited
Loading

Codecov Report

Merging #1912 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1912      +/-   ##
==========================================
- Coverage   74.42%   74.35%   -0.07%     
==========================================
  Files         282      282              
  Lines       13267    13267              
  Branches     2386     2386              
==========================================
- Hits         9874     9865       -9     
- Misses       3262     3265       +3     
- Partials      131      137       +6
Impacted Files Coverage Δ
src/client/debugger/PythonProcess.ts 45.83% <0%> (-5.42%) ⬇️
src/client/unittests/display/main.ts 90.62% <0%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46fbca6...b982639. Read the comment docs.

DonJayamanne
DonJayamanne approved these changes Jun 8, 2018
View reviewed changes
src/test/constants.ts Outdated
}
export const MOCHA_REPORTER_JUNIT: boolean = reportJunit;
export const MOCHA_CI_REPORTFILE: string = MOCHA_REPORTER_JUNIT && process.env.MOCHA_CI_REPORTFILE !== undefined ?
process.env.MOCHA_CI_REPORTFILE.toString() : './junit-out.xml';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

process.env.MOCHA_CI_REPORTFILE!

@d3r3kk d3r3kk merged commit 8009805 into microsoft:master Jun 8, 2018
@d3r3kk d3r3kk deleted the vsts_logging branch June 8, 2018 17:23
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

Assignees

@d3r3kk d3r3kk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the value of MOCHA_CI_REPORTFILE to instigate JUnit report file production during test runs, don't just check for existance.
2 participants
@d3r3kk @DonJayamanne