Skip to content

Turn off virtual env prompt when using create environment command. #19851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
karthiknadig opened this issue Sep 16, 2022 · 2 comments · Fixed by #19925
Closed

Turn off virtual env prompt when using create environment command. #19851

karthiknadig opened this issue Sep 16, 2022 · 2 comments · Fixed by #19925
Assignees
@karthiknadig
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality needs PR Ready to be worked on verified Verification succeeded
Milestone
October 2022

Comments

@karthiknadig
Copy link
Member

No description provided.

@karthiknadig karthiknadig added feature-request Request for new features or functionality area-environments Features relating to handling interpreter environments needs PR Ready to be worked on labels Sep 16, 2022
@karrtikr
Copy link

I believe we discussed that CreateEnvironment should be exposing an API notifying when an environment is being created, which can be used in virtualEnvPrompt.ts. Instead of virtualEnvPrompt.ts exposing an API to turn off the prompt.

@karthiknadig karthiknadig changed the title Provide internal API to turn off environment created notification. Turn off virtual env prompt when using create environment command. Sep 16, 2022
@karthiknadig
Copy link
Member Author

That is correct. Updated the title.

@karthiknadig karthiknadig added triage-needed Needs assignment to the proper sub-team and removed needs PR Ready to be worked on labels Sep 16, 2022
@karthiknadig karthiknadig added needs PR Ready to be worked on and removed triage-needed Needs assignment to the proper sub-team labels Sep 19, 2022
This was referenced Sep 27, 2022
Closed
Merged
karthiknadig added a commit that referenced this issue Oct 3, 2022
@karthiknadig
Fix bugs found during TPI (#19925)
ae63943 
Closes #19889
Closes #19890
Closes #19891
Closes #19894
Closes #19897
Closes #19852
Closes #19851
Closes #19838
Closes #19916
Closes #19917
@karrtikr karrtikr added this to the October 2022 milestone Oct 3, 2022
eleanorjboyd pushed a commit to eleanorjboyd/vscode-python that referenced this issue Oct 4, 2022
@karthiknadig @eleanorjboyd
Fix bugs found during TPI (microsoft#19925)
51d80fe 
Closes microsoft#19889
Closes microsoft#19890
Closes microsoft#19891
Closes microsoft#19894
Closes microsoft#19897
Closes microsoft#19852
Closes microsoft#19851
Closes microsoft#19838
Closes microsoft#19916
Closes microsoft#19917
@karthiknadig karthiknadig added the verified Verification succeeded label Oct 25, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2022
wesm pushed a commit to posit-dev/positron that referenced this issue Mar 28, 2024
@karthiknadig @wesm
Fix bugs found during TPI (microsoft/vscode-python#19925)
56496ab 
Closes microsoft/vscode-python#19889
Closes microsoft/vscode-python#19890
Closes microsoft/vscode-python#19891
Closes microsoft/vscode-python#19894
Closes microsoft/vscode-python#19897
Closes microsoft/vscode-python#19852
Closes microsoft/vscode-python#19851
Closes microsoft/vscode-python#19838
Closes microsoft/vscode-python#19916
Closes microsoft/vscode-python#19917
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karthiknadig karthiknadig

Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality needs PR Ready to be worked on verified Verification succeeded
Projects
None yet
Milestone
October 2022
Development

Successfully merging a pull request may close this issue.

Fix bugs found during TPI karthiknadig/vscode-python
2 participants
@karthiknadig @karrtikr