Skip to content

Make all PR, CI, and Nightly, tasks run in a single step template. #4806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
6 tasks done
d3r3kk opened this issue Mar 18, 2019 · 0 comments
Closed
6 tasks done

Make all PR, CI, and Nightly, tasks run in a single step template. #4806

d3r3kk opened this issue Mar 18, 2019 · 0 comments
Assignees
@d3r3kk
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@d3r3kk
Copy link

d3r3kk commented Mar 18, 2019 •
edited
Loading

To create an Azure DevOps pipeline that is cohesive and more easily understandable, create a single YAML step-template that contains all build & test steps required by our CI/CD processes.

  • Remove the current hierarchy in our Azure DevOps pipelines (definition->job-template->step-template) and make a single step-template instead.
  • Document all build and test steps in the new step-template to make them understandable by anyone with rudimentary knowledge of builds.
  • Add a step for each build/test phase, no iterating or using of variables that are more difficult to understand (and allow for multiple tests to run in a single pipeline job).
  • Add the split-out venv tests template into the new cohesive step-template.
  • Make the CI build use the unified step template.
  • Make the Nightly build use the unified step template.
@d3r3kk d3r3kk added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Mar 18, 2019
@d3r3kk d3r3kk self-assigned this Mar 18, 2019
@d3r3kk d3r3kk mentioned this issue Mar 18, 2019
Closed
9 tasks
d3r3kk added a commit to d3r3kk/vscode-python that referenced this issue Mar 19, 2019
@d3r3kk
Enable venv tests, split out step-template, update CI
49d1b47 
For microsoft#4806, microsoft#4034, others...

- Venv tests are now in the combined step-template for all CI
- PR validation build definition uses the step template
- CI validation build definition uses the step template
  - Runs all tests against all OS, Py 3.7 & 3.6 only
- Some flaky tests skipped (tracked in GH)
- Problems with test runs not finishing in Windows remains

---
@d3r3kk d3r3kk mentioned this issue Mar 19, 2019
Merged
9 tasks
d3r3kk added a commit to d3r3kk/vscode-python that referenced this issue Mar 19, 2019
@d3r3kk
Enable venv tests, split out step-template, update CI
a1d2d4b 
For microsoft#4806, microsoft#4034, others...

- Venv tests are now in the combined step-template for all CI
- PR validation build definition uses the step template
- CI validation build definition uses the step template
  - Runs all tests against all OS, Py 3.7 & 3.6 only
- Some flaky tests skipped (tracked in GH)
- Problems with test runs not finishing in Windows remains

---
d3r3kk added a commit that referenced this issue Mar 19, 2019
@d3r3kk
Enable venv tests, split out step-template, update CI (#4830)
9716f08 
* Enable venv tests, split out step-template, update CI

For #4806, #4034, others...

- Venv tests are now in the combined step-template for all CI
- PR validation build definition uses the step template
- CI validation build definition uses the step template
  - Runs all tests against all OS, Py 3.7 & 3.6 only
- Some flaky tests skipped (tracked in GH)
- Problems with test runs not finishing in Windows remains
@DonJayamanne DonJayamanne mentioned this issue Mar 19, 2019
Closed
8 tasks
d3r3kk added a commit to d3r3kk/vscode-python that referenced this issue Mar 19, 2019
@d3r3kk
Nightly build uses the unified step template
2f88621 
For microsoft#4806

- All builds will now use the unified step template
- Nightly runs
  - All OS variants, multiplied by:
  - All Python versions supported, multiplied by:
  - All tests
- smokeTest has an incoming change before it will be run
- Windows tests regularly fail with  a false negative
- Corrected bug with CI build (3.6 tests actually were running 3.7)

---
@d3r3kk d3r3kk mentioned this issue Mar 19, 2019
Merged
9 tasks
d3r3kk added a commit that referenced this issue Mar 20, 2019
@d3r3kk
Nightly build uses the unified step template (#4838)
faefc70 
For #4806

- All builds will now use the unified step template
- Nightly runs
  - All OS variants, multiplied by:
  - All Python versions supported, multiplied by:
  - All tests
- smokeTest has an incoming change before it will be run
- Windows tests regularly fail with  a false negative
- Corrected bug with CI build (3.6 tests actually were running 3.7)
@d3r3kk d3r3kk closed this as completed Mar 20, 2019
@ghost ghost removed the needs PR label Mar 20, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@d3r3kk d3r3kk

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@d3r3kk