Skip to content

WIP: Update CI build to use the new test-phases.yml steps template. #4812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 30 commits into from

Conversation

d3r3kk
Copy link

@d3r3kk d3r3kk commented Mar 18, 2019

For #4034, #4806, and others...

Make the CI build use the same YAML step-template as the newly developed PR definition (#4806).

Add back the virtual environment tests to the step-template and run them from CI (not for PR) (#4034).


  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@d3r3kk d3r3kk added the no-changelog No news entry required label Mar 18, 2019
@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #4812 into master will decrease coverage by 16%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #4812     +/-   ##
========================================
- Coverage      77%     62%    -15%     
========================================
  Files         450     373     -77     
  Lines       21733   14706   -7027     
  Branches     3577    1170   -2407     
========================================
- Hits        16679    9040   -7639     
- Misses       5050    5464    +414     
- Partials        4     202    +198
Flag Coverage Δ
#Linux ?
#Windows ?
#macOS ?

@d3r3kk d3r3kk force-pushed the 4806_add_venv_tests branch 2 times, most recently from 1ce7a24 to 191783b Compare March 19, 2019 17:21
d3r3kk added 26 commits March 19, 2019 11:05
- will re-use the steps in CI and Nightly
- was running Python 3.7 in all cases before
- Updated AGENT_OS usage
- Add display name to show dependency versions (was 'Bash')
- skip Python unittests for normalizeForInterpreter in python 2.7
- run them before system tests in the interest of early exit for fast tests
- Do not run internal-tool tests on Python != 3.x
- Remove the temp trigger I had from before
- Add .Venv tests to the build
- Update CI tests to make use of the step-template created for PR
- put CI definition in place of PR to test it
- Fix configuration of venv tests (needs python test reqs)
- Update names of PR and CI builds
- Replacement variable in path needs to be in quotes.
- Skipping test has to be refactored in Jupyter test suite
- tracked by #4820
- correct issue with skip of test in notebook functional tests.
- Based on an environment variable
- If env var is present, split the test files to add to mocha
- env var is [slice_to_run]/[total_slices]
- Split across 4 slices for all testSingle and testMultiWorkspaces tests
- Add mocha.checkForLeaks on split windows tests
d3r3kk added 3 commits March 19, 2019 11:06
- Move CI_PYTHON_PATH setting to after venv tests
  - CI_PYTHON_PATH breaks the venv tests.
- Remove flaky test from functional tests on Windows - GH #4827
@d3r3kk d3r3kk force-pushed the 4806_add_venv_tests branch from 191783b to 1bdf736 Compare March 19, 2019 18:06
@d3r3kk
Copy link
Author

d3r3kk commented Mar 19, 2019

Superseded by #4830

@d3r3kk d3r3kk closed this Mar 19, 2019
@d3r3kk d3r3kk deleted the 4806_add_venv_tests branch March 19, 2019 22:19
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant