Add extension dependencies at build time

[joyceerhl]

For #14635

• Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
• Title summarizes what is changing.
• Has a news entry file (remember to thank yourself!).
• Appropriate comments and documentation strings in the code.
• Has sufficient logging.
• Has telemetry for enhancements.
• Unit tests & system/integration tests are added/updated.
• Test plan is updated as appropriate.
• package-lock.json has been regenerated by running npm install (if dependencies have changed).
• The wiki is updated with any design decisions/details.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
No Duplication information

[codecov-io]

Codecov Report

Merging #14636 into main will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #14636      +/-   ##
==========================================
+ Coverage   65.08%   65.10%   +0.01%     
==========================================
  Files         541      541              
  Lines       25377    25377              
  Branches     3587     3587              
==========================================
+ Hits        16516    16521       +5     
+ Misses       8179     8178       -1     
+ Partials      682      678       -4     

Impacted Files	Coverage Δ
src/client/activation/languageClientMiddleware.ts	32.46% <0.00%> (ø)
...tascience/languageserver/notebookConcatDocument.ts
...nt/datascience/languageserver/notebookConverter.ts
...ascience/languageserver/notebookMiddlewareAddon.ts
...client/jupyter/languageserver/notebookConverter.ts	1.67% <0.00%> (ø)
.../jupyter/languageserver/notebookMiddlewareAddon.ts	3.84% <0.00%> (ø)
...t/jupyter/languageserver/notebookConcatDocument.ts	7.81% <0.00%> (ø)
src/client/common/process/proc.ts	15.21% <0.00%> (+0.72%)	⬆️
.../locators/services/virtualEnvironmentIdentifier.ts	91.78% <0.00%> (+1.36%)	⬆️
.../pythonEnvironments/common/externalDependencies.ts	74.46% <0.00%> (+2.12%)	⬆️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 598d849...c3ec59e. Read the comment docs.

[joyceerhl]

I imagine this also needs to go into the release branch? @karthiknadig

[karthiknadig]

This and few other things... I will pull them all to the release branch

[karrtikr]

@joyceerhl GHA builds corresponding to this PR are failing: https://github.com/microsoft/vscode-python/actions/runs/348408071 can you please check?

[brettcannon]

This PR has broken CI: https://github.com/microsoft/vscode-python/actions/runs/348408071

[joyceerhl]

Sorry guys, investigating. I initially suspected a problem with smoke tests running with the VSIX, but it looks like the Build VSIX step itself is failing.

The GHA runs for the commit before this were fine. The difference is here:

> node-pre-gyp install --fallback-to-build

node-pre-gyp WARN Using request for node-pre-gyp https download 
[canvas] Success: "/home/runner/work/vscode-python/vscode-python/node_modules/canvas/build/Release/canvas.node" is installed via remote

versus after this PR went in:

> node-pre-gyp install --fallback-to-build

node-pre-gyp WARN Using request for node-pre-gyp https download 
node-pre-gyp WARN Tried to download(404): https://github.com/node-gfx/node-canvas-prebuilt/releases/download/v2.6.0/canvas-v2.6.0-node-v83-linux-glibc-x64.tar.gz 
node-pre-gyp WARN Pre-built binaries not found for [email protected] and [email protected] (node-v83 ABI, glibc) (falling back to source compile with node-gyp) 

I do not see an asset matching https://github.com/node-gfx/node-canvas-prebuilt/releases/download/v2.6.0/canvas-v2.6.0-node-v83-linux-glibc-x64.tar.gz at https://github.com/node-gfx/node-canvas-prebuilt/releases/tag/v2.6.0. Still investigating but wanted to quickly mention that I am looking into it and it's not yet clear to me how this PR could be causing this problem.

[kimadeline]

Is this related to the rollout of Node 14.X: actions/runner-images#1953 (@brettcannon mentioned it offline)?

The Ubuntu image changed between the last working commit and this one:

• fine with Node 12.19.0: https://github.com/actions/virtual-environments/blob/ubuntu18/20201026.1/images/linux/Ubuntu1804-README.md
• not fine with Node 14.15.0: https://github.com/actions/virtual-environments/blob/releases/Ubuntu18/20201102/images/linux/Ubuntu1804-README.md

[joyceerhl]

Yes that seems likely. IIRC our pipelines have used Node 12.15.x in the past. We'd want to use https://github.com/actions/setup-node to configure GHA with Node 12.X

[joyceerhl]

Edit: Oops, was looking at the wrong repo's configs

There's a setup-node step defined in insiders.yml and release.yml, but it's being skipped for some reason:

      - name: Use Node ${{env.NODE_VERSION}}
        uses: actions/[email protected]
        with:
          node-version: ${{env.NODE_VERSION}}~

[kimadeline]

I believe we only use it for tests at the moment, and even then we set it up only if the previous step was successful (which wasn't the case). It should probably be moved to be the first step of the test job yeah.

[joyceerhl]

Opened this PR to address the Node version issue: #14641

[joyceerhl]

I believe the failures have been resolved: https://github.com/microsoft/vscode-python/actions/runs/348786875 Thanks @kimadeline for the pointer to the Node 14.x rollout, that was indeed the problem!