Skip to content

Fix process picker #14700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2020
Merged

Fix process picker #14700

merged 2 commits into from
Nov 12, 2020

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Nov 11, 2020

For #14678

More details: microsoft/vscode#110432.

@karrtikr karrtikr added the no-changelog No news entry required label Nov 11, 2020
@codecov-io
Copy link

codecov-io commented Nov 11, 2020

Codecov Report

Merging #14700 (bc36f29) into main (2020d62) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #14700      +/-   ##
==========================================
- Coverage   65.02%   64.88%   -0.15%     
==========================================
  Files         543      547       +4     
  Lines       25425    25616     +191     
  Branches     3593     3619      +26     
==========================================
+ Hits        16532    16620      +88     
- Misses       8216     8315      +99     
- Partials      677      681       +4     
Impacted Files Coverage Δ
src/client/common/utils/icons.ts 85.71% <100.00%> (+2.38%) ⬆️
src/client/pythonEnvironments/base/locatorUtils.ts 60.46% <0.00%> (-37.58%) ⬇️
src/client/pythonEnvironments/base/locators.ts 55.26% <0.00%> (-18.08%) ⬇️
src/client/pythonEnvironments/base/envsCache.ts 72.54% <0.00%> (-12.64%) ⬇️
src/client/common/utils/platform.ts 60.00% <0.00%> (-12.00%) ⬇️
src/client/pythonEnvironments/base/info/env.ts 69.62% <0.00%> (-10.77%) ⬇️
src/client/pythonEnvironments/legacyIOC.ts 36.77% <0.00%> (-3.36%) ⬇️
.../pythonEnvironments/common/externalDependencies.ts 72.34% <0.00%> (-2.13%) ⬇️
...ient/pythonEnvironments/base/info/pythonVersion.ts 74.54% <0.00%> (-1.93%) ⬇️
src/client/common/configSettings.ts 67.67% <0.00%> (-1.88%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2020d62...bc36f29. Read the comment docs.

@karrtikr karrtikr changed the title Workaround VSCode bug for process picker Fix process picker Nov 12, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karrtikr karrtikr merged commit e1cc8b2 into microsoft:main Nov 12, 2020
@karrtikr karrtikr deleted the proesspicker branch November 12, 2020 21:13
karthiknadig pushed a commit to karthiknadig/vscode-python that referenced this pull request Nov 17, 2020
* Workaround VSCode bug for process picker

* Fix how we pass in icons to VSCode
karthiknadig added a commit that referenced this pull request Nov 17, 2020
* Point release change log and version update

* Fix process picker (#14700)

* Workaround VSCode bug for process picker

* Fix how we pass in icons to VSCode

* update change log with cherry pick

Co-authored-by: Kartik Raj <[email protected]>
karthiknadig added a commit that referenced this pull request Nov 26, 2020
* Cherry pick from main (#14644)

* Update shipped wheels version (#14615)

* Update shipped wheels version

* News item

* Remove redundant files (#14620)

* Add extension dependencies at build time (#14636)

* Use Node 12.15 in Insiders and Release GitHub Actions (#14641)

* Use Node 12.15 on all Insiders and Release GitHub Actions jobs (#14642)

Co-authored-by: Joyce Er <[email protected]>

* Cherry pic fixes into release for tests. (#14673)

* Added FSWatching base class and made related changes (#14605)

* Add FSWatching locator base class

* Correct glob pattern to not match python3.2whoa

* Add documentation of python binary watcher

* Fix lint errors

* Update ignore list

* Add disposable registry

* Modify FSWatching Locator

* Code reviews

* Use string[]

* Remove list disposable getter

* Fix failing global virtual env watcher tests (#14633)

Co-authored-by: Kartik Raj <[email protected]>

* Version, change log and cherrypicks for nov release (#14696)

* change log updates

* Update gifs

* Fix for interpreter selection (#14693)

* Fix for interpreter selection

* Fix linting errors

* Minor tweak to property removal

* Cherry pick "Bind function to correct this for workspace syms" (#14743)

* Fix #14674: Enable overriding "pythonPath" in the launcher

Fix #12462: Update launch.json schema to add "python" and remove "pythonPath"

Split the "pythonPath" debug property into "python", "debugAdapterPython", and "debugLauncherPython".

Do most debug config validation on fully expanded property values via resolveDebugConfigurationWithSubstitutedVariables().

Add fixups for legacy launch.json with "pythonPath".

* Point release change log and version update (#14750)

* Point release change log and version update

* Fix process picker (#14700)

* Workaround VSCode bug for process picker

* Fix how we pass in icons to VSCode

* update change log with cherry pick

Co-authored-by: Kartik Raj <[email protected]>

Co-authored-by: Joyce Er <[email protected]>
Co-authored-by: Kartik Raj <[email protected]>
Co-authored-by: Jake Bailey <[email protected]>
Co-authored-by: Pavel Minaev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants