Skip to content

Conversation

@georgend
Copy link
Contributor

@georgend georgend commented Jun 10, 2020

Address AB#4768

Changes proposed in this pull request

  • CompressionHandler currently doesn't forward HttpContent headers to the next middleware in the chain. This change fixes that by copying the headers from the source HttpContent to the destination StreamHttpContent.
  • Adds tests to confirm custom and content headers are always copied after compression.

zengin
zengin previously approved these changes Jun 11, 2020
peombwa
peombwa previously approved these changes Jun 11, 2020
andrueastman
andrueastman previously approved these changes Jun 15, 2020
Ensure that compressed data is the same as decompressed data.
@georgend georgend dismissed stale reviews from andrueastman, peombwa, and zengin via 6407805 June 17, 2020 22:17
@georgend georgend merged commit 6563254 into dev Jun 18, 2020
@georgend georgend deleted the compressionHeaderHandling branch June 18, 2020 18:05
MIchaelMainer pushed a commit that referenced this pull request Jul 28, 2020
* Support native platform Http handlers for Xamarin.Mac
* Update macOS to use NSUrlSessionHandler in foundation namespace - support for Xamarin.Mac20
* Compression header handling (#118)
MIchaelMainer added a commit that referenced this pull request Oct 6, 2020
* Support native plaform Http handlers for Xamarin.Mac
* Update macOS to use NSUrlSessionHandler in foundation namespace.
* Add support for Xamarin.Mac20
* Compression header handling (#118)
* Copy Http Content headers to the destination stream in compression handler.
* Ensure headers are not empty.
* Ensure that compressed data is the same as decompressed data.
* Add `IBaseRequestBuilder` interface to `BaseRequestBuilder` class (#128)
* Update Microsoft.Graph.Core.csproj (#129)
* Use new service connection (#130)
* Fixes deserialization of OData primitive types (#135)

Adds intermediate response objects for deserialization of OData primitives.

	new file:   src/Microsoft.Graph.Core/Models/ODataMethodInt64Response.cs
	new file:   src/Microsoft.Graph.Core/Models/ODataMethodInt32Response.cs
	new file:   src/Microsoft.Graph.Core/Models/ODataMethodBooleanResponse.cs
	new file:   src/Microsoft.Graph.Core/Models/ODataMethodStringResponse.cs
andrueastman pushed a commit that referenced this pull request Dec 7, 2020
* Copy Http Content headers to the destination stream in compression handler.

* Ensure headers are not empty.

* Ensure that compressed data is the same as decompressed data.

Co-authored-by: George <[email protected]>
@andrueastman andrueastman mentioned this pull request Dec 8, 2020
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants