Skip to content

Invoke-GraphRequest cmdlet to allow direct requests using underlying HttpClient #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jul 15, 2020
Merged

Invoke-GraphRequest cmdlet to allow direct requests using underlying HttpClient #245

merged 21 commits into from
Jul 15, 2020

Conversation

georgend
Copy link
Contributor

@georgend georgend commented Jun 2, 2020 •
edited
Loading

Adds an Invoke-GraphRequest cmdlet that enables users to make requests using the underlying authenticated HttpClient.

Example

Invoke-GraphRequest -Method GET -Uri https://graph.microsoft.com/beta/me
Invoke-GraphRequest -Method GET -Uri /beta/me

To support non-json responses requires a change in msgraph-sdk-dotnet-core whose compression handler currently doesn't pass along Http Content headers to the next middleware in the pipeline

Address AB#4897

@georgend georgend requested a review from peombwa June 2, 2020 13:35
@georgend georgend linked an issue Jun 2, 2020 that may be closed by this pull request
[FeatureRequest] New Command Get-GraphClient that returns the httpclient used by the module. #127
Closed
ddyett
ddyett reviewed Jun 2, 2020
View reviewed changes
ddyett
ddyett reviewed Jun 2, 2020
View reviewed changes
MIchaelMainer
MIchaelMainer reviewed Jun 4, 2020
View reviewed changes
- Enable users to specify their own Token (UserProvidedToken)
d8f0cc7 
- Enable users to download files to current directory either with custom name or inferred name.
- Enable users to pass their own headers.
- When Errors happen, print out the whole HttpResponse including headers.
- Enable -PassThru, -Verbose (with useful messages)
MIchaelMainer
MIchaelMainer reviewed Jun 24, 2020
View reviewed changes
@ddyett ddyett requested a review from zengin June 26, 2020 15:19
peombwa
peombwa suggested changes Jun 26, 2020
View reviewed changes
zengin
zengin reviewed Jun 29, 2020
View reviewed changes
zengin
zengin reviewed Jun 29, 2020
View reviewed changes
zengin
zengin reviewed Jun 29, 2020
View reviewed changes
zengin
zengin reviewed Jun 29, 2020
View reviewed changes
zengin
zengin reviewed Jun 29, 2020
View reviewed changes
src/Authentication/Authentication/Cmdlets/InvokeGraphRequest.cs
{
GraphRequestSession.ContentHeaders.Add(entry.Key, entry.Value);
}
else
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else if

zengin
zengin reviewed Jun 29, 2020
View reviewed changes
zengin
zengin reviewed Jun 30, 2020
View reviewed changes
zengin
zengin reviewed Jun 30, 2020
View reviewed changes
zengin
zengin reviewed Jun 30, 2020
View reviewed changes
zengin
zengin reviewed Jun 30, 2020
View reviewed changes
zengin
zengin suggested changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@zengin zengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider using functionality from standard library whenever possible.

zengin
zengin reviewed Jul 13, 2020
View reviewed changes
zengin
zengin approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@zengin zengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me for local changes, please wait for approval from someone who knows the high level functionality better.

peombwa
peombwa approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@peombwa peombwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgend georgend merged commit 3cb927d into dev Jul 15, 2020
@georgend georgend linked an issue Jul 18, 2020 that may be closed by this pull request
Connect using BYOT via a Managed Identity in Azure Functions #46
Closed
@georgend georgend deleted the invokeGraphRequest branch July 22, 2020 22:58
@peombwa peombwa mentioned this pull request Aug 12, 2020
Merged
@MIchaelMainer MIchaelMainer mentioned this pull request Oct 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zengin zengin zengin approved these changes

@peombwa peombwa peombwa approved these changes

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@ddyett ddyett Awaiting requested review from ddyett

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@georgend @zengin @peombwa @MIchaelMainer @ddyett