refactor: rewrite listParts in TypeScript

[trim21]

No description provided.

[prakashsvmx]

var s3Client = new Minio.Client({
    endPoint: 's3.amazonaws.com',
    accessKey: 's3accssKey',
    secretKey: 's3secretkey',
    //region: 'us-east-1',
    // pathStyle: true,
    // useSSL: true,
})

Specifically with s3,
, if no region is specified,
TypeError: Invalid region: undefined is thrown.

MinIO does not care about region.

[trim21]

var s3Client = new Minio.Client({
    endPoint: 's3.amazonaws.com',
    accessKey: 's3accssKey',
    secretKey: 's3secretkey',
    //region: 'us-east-1',
    // pathStyle: true,
    // useSSL: true,
})

Specifically with s3, , if no region is specified, TypeError: Invalid region: undefined is thrown.

MinIO does not care about region.

can you paste full stack trace?

[prakashsvmx]

With older versions, with or without region specified in client options, it works.
with this pr, it does not work as expected. may be the default region is not used i guess.

var s3Client = new Minio.Client({
    endPoint: 's3.amazonaws.com',
    accessKey: 's3-acc-key',
    secretKey: 's3-password-tbd,
    region: 'us-east-1', // try with or without region. prior releases work as expected. 
    //pathStyle: true,
    //useSSL: true,
})

s3Client.traceOn()

const checkConn = () => {
    const objectName = '1.png'
    const bucketName = 'sph-test-inc-upld'
    s3Client.statObject(bucketName, objectName, (e, d) => {
        console.log(e, d)
    })
}

Trace without region specified

REQUEST: GET /sph-test-inc-upld?location
host: s3.amazonaws.com
user-agent: MinIO (linux; x64) minio-js/7.1.2
x-amz-date: 20230602T072956Z
x-amz-content-sha256: UNSIGNED-PAYLOAD
authorization: AWS4-HMAC-SHA256 Credential=*REDACTED*/20230602/us-east-1/s3/aws4_request, SignedHeaders=host;x-amz-content-sha256;x-amz-date, Signature=**REDACTED**

RESPONSE: 200
x-amz-id-2: Gz66xxXsGF/dTBI6mUtzTC8YnjoMUX8zmDIrhKJUUgzcz8pOqHhCuih2CTMct7vrjV4x2WwSvSE=
x-amz-request-id: 4DMRG7P9217KS5A9
date: Fri, 02 Jun 2023 07:29:58 GMT
content-type: application/xml
transfer-encoding: chunked
server: AmazonS3
connection: close

S3Error: 400
    at Object.parseResponseError (/home/prakash/MinIO/GIT/sdks/minio-js/dist/main/internal/xml-parser.js:82:13)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Client.makeRequestStreamAsync (/home/prakash/MinIO/GIT/sdks/minio-js/dist/main/internal/client.js:465:19) {
  code: 'UnknownError',
  amzRequestid: 'QAV1HKWZ8K42HBF4',
  amzId2: 'dzxhKWk7kaEZuQDiVIirrq3lHhuIgzKEu4wIn4YXeETY5vs8Iww1lDbgQ7F2FIZ+sfXM3L4W0LQ=',
  amzBucketRegion: undefined,
  [cause]: {
    amzRequestid: 'QAV1HKWZ8K42HBF4',
    amzId2: 'dzxhKWk7kaEZuQDiVIirrq3lHhuIgzKEu4wIn4YXeETY5vs8Iww1lDbgQ7F2FIZ+sfXM3L4W0LQ=',
    amzBucketRegion: undefined
  }
} undefined

[trim21]

With older versions, with or without region specified in client options, it works. with this pr, it does not work as expected. may be the default region is not used i guess.

var s3Client = new Minio.Client({
    endPoint: 's3.amazonaws.com',
    accessKey: 's3-acc-key',
    secretKey: 's3-password-tbd,
    region: 'us-east-1', // try with or without region. prior releases work as expected. 
    //pathStyle: true,
    //useSSL: true,
})

s3Client.traceOn()

const checkConn = () => {
    const objectName = '1.png'
    const bucketName = 'sph-test-inc-upld'
    s3Client.statObject(bucketName, objectName, (e, d) => {
        console.log(e, d)
    })
}

Trace without region specified

REQUEST: GET /sph-test-inc-upld?location
host: s3.amazonaws.com
user-agent: MinIO (linux; x64) minio-js/7.1.2
x-amz-date: 20230602T072956Z
x-amz-content-sha256: UNSIGNED-PAYLOAD
authorization: AWS4-HMAC-SHA256 Credential=*REDACTED*/20230602/us-east-1/s3/aws4_request, SignedHeaders=host;x-amz-content-sha256;x-amz-date, Signature=**REDACTED**

RESPONSE: 200
x-amz-id-2: Gz66xxXsGF/dTBI6mUtzTC8YnjoMUX8zmDIrhKJUUgzcz8pOqHhCuih2CTMct7vrjV4x2WwSvSE=
x-amz-request-id: 4DMRG7P9217KS5A9
date: Fri, 02 Jun 2023 07:29:58 GMT
content-type: application/xml
transfer-encoding: chunked
server: AmazonS3
connection: close

S3Error: 400
    at Object.parseResponseError (/home/prakash/MinIO/GIT/sdks/minio-js/dist/main/internal/xml-parser.js:82:13)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Client.makeRequestStreamAsync (/home/prakash/MinIO/GIT/sdks/minio-js/dist/main/internal/client.js:465:19) {
  code: 'UnknownError',
  amzRequestid: 'QAV1HKWZ8K42HBF4',
  amzId2: 'dzxhKWk7kaEZuQDiVIirrq3lHhuIgzKEu4wIn4YXeETY5vs8Iww1lDbgQ7F2FIZ+sfXM3L4W0LQ=',
  amzBucketRegion: undefined,
  [cause]: {
    amzRequestid: 'QAV1HKWZ8K42HBF4',
    amzId2: 'dzxhKWk7kaEZuQDiVIirrq3lHhuIgzKEu4wIn4YXeETY5vs8Iww1lDbgQ7F2FIZ+sfXM3L4W0LQ=',
    amzBucketRegion: undefined
  }
} undefined

So this doesn't happened in current master branch, but on 5c91791?

[prakashsvmx]

I tested with the past two releases. I can check on master and confirm.

[trim21]

this may be caused by #1156

[prakashsvmx]

may be. in master, i am seeing the below in both (with/without region) cases

 ➜ node examples/put-object.js
TypeError: Invalid region: undefined
    at getS3Endpoint (/home/prakash/MinIO/GIT/sdks/minio-js/dist/main/internal/s3-endpoints.js:48:11)
    at Client.getRequestOptions (/home/prakash/MinIO/GIT/sdks/minio-js/dist/main/internal/client.js:223:47)
    at Client.makeRequestStreamAsync (/home/prakash/MinIO/GIT/sdks/minio-js/dist/main/internal/client.js:438:29) undefined

[trim21]

should fix this first...

[trim21]

@prakashsvmx please try #1165 ， I tested on s3， it looks fine。

[prakashsvmx]

LGTM 👍

[aldy505]

So far it's all good (I can't press approve as the button is disabled), just a few notes that might be discussed.

[trim21]

@kaankabalak please？

[kaankabalak]

LGTM