-
Notifications
You must be signed in to change notification settings - Fork 309
fix: s3 region undefined #1165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: s3 region undefined #1165
Conversation
aldy505
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. this means we got to do more integration testing
|
without region specified, the following is the error . so looks like the default region is not applied. |
|
should be fixed |
prakashsvmx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. LGTM 👍
mc mb --region=us-west-2 s3/sph-region-bucket
➜ mc cp ~/Pictures/10.png s3/sph-region-bucket/1.png
var s3Client = new Minio.Client({
endPoint: 's3.amazonaws.com',
accessKey: 's3AccesKey',
secretKey: 's3Secretkey,
region: 'us-west-2',// with/without/default region.
//pathStyle: true,
//useSSL: true,
})
aldy505
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
s3 doesn't always return bucket region, need to fallback to default region.
This bug is added by #1156