refactor `setObjectLegalHold` and `getObjectLegalHold` apis #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

prakashsvmx merged 7 commits into minio:master from prakashsvmx:ref-get-set-legal-hold

Sep 14, 2023

Member

prakashsvmx commented Aug 2, 2023

refactor setObjectLegalHold and getObjectLegalHold api

prakashsvmx self-assigned this

prakashsvmx force-pushed the ref-get-set-legal-hold branch from c5d88db to 9d28a33 Compare

August 2, 2023 12:30

prakashsvmx marked this pull request as ready for review

August 2, 2023 12:40

prakashsvmx requested a review from kaankabalak

August 2, 2023 12:41

kaankabalak reviewed

View reviewed changes

examples/get-object-legal-hold.mjs Outdated Show resolved Hide resolved

kaankabalak reviewed

View reviewed changes

examples/get-object-legal-hold.mjs Outdated Show resolved Hide resolved

kaankabalak reviewed

View reviewed changes

examples/get-object-legal-hold.mjs Outdated Show resolved Hide resolved

kaankabalak reviewed

View reviewed changes

docs/API.md Outdated Show resolved Hide resolved

kaankabalak reviewed

View reviewed changes

src/internal/client.ts Show resolved Hide resolved

kaankabalak reviewed

View reviewed changes

docs/API.md Outdated Show resolved Hide resolved

trim21 reviewed

View reviewed changes

src/internal/client.ts Outdated Show resolved Hide resolved

trim21 reviewed

View reviewed changes

src/internal/client.ts Show resolved Hide resolved

trim21 reviewed

View reviewed changes

src/internal/client.ts Outdated Show resolved Hide resolved

trim21 reviewed

View reviewed changes

src/minio.d.ts Show resolved Hide resolved

prakashsvmx force-pushed the ref-get-set-legal-hold branch from 9a63ad1 to 292001c Compare

August 11, 2023 06:58

prakashsvmx added 5 commits

September 1, 2023 17:17


          refactor setObjectLegalHold and getObjectLegalHold api

62fcd95


          address review comments

486a2fb


          address some more review comments

72db424


          address clean up

f365cad


          address suggestions

e014662

prakashsvmx force-pushed the ref-get-set-legal-hold branch 2 times, most recently from 85daed0 to e014662 Compare

September 5, 2023 06:10

kaankabalak previously approved these changes

View reviewed changes

prakashsvmx requested a review from trim21

September 13, 2023 12:31

trim21 reviewed

View reviewed changes

src/internal/client.ts Show resolved Hide resolved

trim21 reviewed

View reviewed changes

src/internal/client.ts Show resolved Hide resolved

trim21 reviewed

View reviewed changes

src/internal/client.ts Show resolved Hide resolved

trim21 reviewed

View reviewed changes

src/internal/client.ts Outdated Show resolved Hide resolved

src/internal/type.ts Show resolved Hide resolved


          fix revised comments

8d3adc2

prakashsvmx dismissed kaankabalak’s stale review via

8d3adc2

September 14, 2023 06:11

prakashsvmx force-pushed the ref-get-set-legal-hold branch from f8d3c9f to 8d3adc2 Compare

September 14, 2023 06:11


          Merge branch 'master' into ref-get-set-legal-hold

8b48873

trim21 reviewed

View reviewed changes

Contributor

trim21 left a comment

LGTM

kaankabalak approved these changes

View reviewed changes

prakashsvmx merged commit a3ff47c into minio:master

prakashsvmx deleted the ref-get-set-legal-hold branch

September 14, 2023 13:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet