Skip to content

Major issue -dependency on reactor, slf4j and netty #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hrstoyanov opened this issue Mar 10, 2025 · 4 comments · May be fixed by #175
Open

Major issue -dependency on reactor, slf4j and netty #38

hrstoyanov opened this issue Mar 10, 2025 · 4 comments · May be fixed by #175

Comments

@hrstoyanov
Copy link

hrstoyanov commented Mar 10, 2025 •
edited
Loading

This project requires reactor (and therefore - netty), slf4j for reasons I cannot understand. In its current state it is more like "Spring MCP SDK" rather than "Java MCP SDK", so at least change the project title.

Java already has virtual threads and therefore, there is no need for any reactive frameworks. Also, since Java 9+ there is also a built-in logging facade System.Logger , so there is no need for slf4j either.

The use of jackson is also problematic - ideally there should be 2 modules - for jackson and standard jsonp.

Please clean it up.
edburns added a commit to azure-javaee/mcp-java-sdk that referenced this issue Apr 18, 2025
@edburns
On branch edburns/38-reactor-mcp-sdk Fixes modelcontextprotocol#38, b…
b4f99a0 
…ut in a very trivial way.

modified:   README.md
modified:   mcp/pom.xml

@hrstoyanov wrote:

> This project requires reactor (and therefore - netty), slf4j for reasons I cannot understand. In its current state it is more like "Spring MCP SDK" rather than "Java MCP SDK", so at least change the project title.

I realize @tzolov proposed a [remedy](https://github.com/orgs/modelcontextprotocol/discussions/246#discussioncomment-12854366), but even that seems problematic because it introduces a dependency on RS Publisher.

In the meantime, please consider this trivial PR, which implements "at least change the project title."

Signed-off-by: Ed Burns <[email protected]>
@edburns edburns linked a pull request Apr 19, 2025 that will close this issue
Open
3 tasks
@edburns
Copy link

edburns commented Apr 19, 2025

Hello @hrstoyanov please consider this PR: #175 .

@hrstoyanov
Copy link
Author

Changing the title is the proper way for this situation

@Aliaksie
Copy link
Contributor

Hi! I created a PR that I hope will help with this!

@hrstoyanov
Copy link
Author

@Aliaksie the proper way is to avoid any of the reactive frameworks, but use java virtual threads.

Likewise , remove slf4j and use java System.Logger facade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

On branch edburns/38-reactor-mcp-sdk Fixes #38, but in a very trivial way. azure-javaee/mcp-java-sdk
3 participants
@edburns @hrstoyanov @Aliaksie