On branch edburns/38-reactor-mcp-sdk Fixes #38, but in a very trivial way. #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut in a very trivial way. modified: README.md modified: mcp/pom.xml @hrstoyanov wrote: > This project requires reactor (and therefore - netty), slf4j for reasons I cannot understand. In its current state it is more like "Spring MCP SDK" rather than "Java MCP SDK", so at least change the project title. I realize @tzolov proposed a [remedy](https://github.com/orgs/modelcontextprotocol/discussions/246#discussioncomment-12854366), but even that seems problematic because it introduces a dependency on RS Publisher. In the meantime, please consider this trivial PR, which implements "at least change the project title." Signed-off-by: Ed Burns <[email protected]>
|
Makes total sense. The project title needs to describe this implementation more accurately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38 but only in a very trivial way.
modified: README.md
modified: mcp/pom.xml
@hrstoyanov wrote:
I realize @tzolov proposed a remedy, but even that seems problematic because it introduces a dependency on RS Publisher.
In the meantime, please consider this trivial PR, which implements "at least change the project title."
Motivation and Context
Fixes #38, but only in a very trivial way
How Has This Been Tested?
Documentation only.
Breaking Changes
No
Types of changes
Checklist
Additional context
I represent a decades long commitment to vendor neutrality in Java standards. Introducing non-neutral dependencies tarnishes the ability of MCP to legitimately call itself a standard.