feat(spi): adds implementation-neutral SPI module #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Aliaksie
force-pushed
the
feat/mcp-spi
branch
2 times, most recently
from
efa638e to
9d7ed54
Compare
Aliaksie
changed the title
|
Hey @tzolov, hope you're doing well! Just wanted to check in — have you had a chance to review this PR? I’d appreciate any feedback when you get a moment. Looking forward to your thoughts! |
Aliaksie
force-pushed
the
feat/mcp-spi
branch
2 times, most recently
from
9432f3c to
58173e5
Compare
Aliaksie
force-pushed
the
feat/mcp-spi
branch
2 times, most recently
from
2dac2b3 to
62b6f8a
Compare
|
Hi @tzolov👋 Just checking in to see if there’s been a chance to review this PR I’d love to get your thoughts on whether this is a direction the project is open to, or if there’s anything I should revise to help move it forward. Happy to discuss further or break it into smaller pieces if that helps with review. |
7 tasks
134130
reviewed
Jun 11, 2025
| <version>${project.version}</version> | ||
| </dependency> | ||
|
|
||
| <!-- MCP Jacson Schema --> |
There was a problem hiding this comment.
Suggested change
| <!-- MCP Jacson Schema --> | |
| <!-- MCP Jackson Schema --> |
A nit typo!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the first version of the
mcp-spimodule to define a transport-agnostic, reactive-compatible interface for the Model Context Protocol Java SDK.Refactor mcp to optionally log via a pluggable logger interface (McpTransportLogger interface in
mcp-spiinstead of hard SLF4J dependency).Key changes:
mcp-spi(transport interfaces, Jackson-free schema types, McpSchemaCodec abstraction, McpClient/McpServer abstraction, McpLogger pluggable logger interface)mcp-schema-jacksonJackson-based schema + McpSchemaCodec implementationmcp-logging-slf4jslf4j-based implementation of McpLoggermcptomcp-reactormcp-reactorto usemcp-spiandmcp-schema-jackson(as default codec implementation) andmcp-logging-slf4j(as default McpLogger implementation)mcp-reactorMotivation and Context
The motivation behind this change is to make the SDK modular, implementation-agnostic, and easier to integrate with diverse runtime environments.
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context
Possible Future Work:
mcp-spi-tck).mcp-vertx), Java 11+ Flow.Publisher HTTP client(mcp-flow)mcp-schema-gson,mcp-schema-cbor,mcp-schema-protobuf).p.s. if these changes don't make sense no problem just close this pr :-)