Skip to content

GODRIVER-1951 Update the Go version for Evergreen builds to 1.16 #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2021
Merged

GODRIVER-1951 Update the Go version for Evergreen builds to 1.16 #663

merged 2 commits into from
May 11, 2021

Conversation

matthewdale
Copy link
Collaborator

@matthewdale matthewdale commented May 7, 2021 •
edited
Loading

Update the Go version for Evergreen builds to 1.16

Changes:

  • Update the Evergreen Go version for tests to 1.16
  • Add an condition to disable client-side encryption tests on Ubuntu 14.04. Attempting to build with client-side encryption enabled results in error:
# go.mongodb.org/mongo-driver/event.test
.../go1.16/pkg/tool/linux_amd64/link: running gcc failed: exit status 1
/usr/bin/ld: /.../go-link-721235335/000014.o: unrecognized relocation (0x2a) in section `.text'
/usr/bin/ld: final link failed: Bad value
collect2: error: ld returned 1 exit status

See golang/go#43996 for more information.

  • Fix a typo in the Makefile target evg-test-load-balancers

@matthewdale matthewdale force-pushed the godriver1951-update-go-116 branch from f7ab33b to 052961b Compare May 8, 2021 00:24
benjirewis
benjirewis reviewed May 10, 2021
View reviewed changes
Copy link
Contributor

@benjirewis benjirewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me, could you reconfigure the linked patch to run all tasks we have (or at least this ones modified to use go 1.16), so we can see that they pass?

@matthewdale matthewdale force-pushed the godriver1951-update-go-116 branch from 052961b to da9d7d9 Compare May 10, 2021 23:25
kevinAlbs
kevinAlbs approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment update!

.evergreen/config.yml Outdated
# The GCC toolchain that comes with Ubuntu 14.04 is incompatible with the standard binary
# release of Go 1.16. As a result, Cgo builds on Ubuntu 14.04 fail with a linking error
# (see https://github.com/golang/go/issues/43996). On Ubuntu 14.04, we only run tests for
# server v2.6, which doesn't support client-side encryption. Exclude all build tags to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ubuntu 14.04 also runs against the server v3.0.

Suggested change
# server v2.6, which doesn't support client-side encryption. Exclude all build tags to
# server v2.6 and v3.0, which doesn't support client-side encryption. Exclude all build tags to

In case it is helpful, the support of server versions on different platforms found on: https://docs.mongodb.com/manual/administration/production-notes/
The version selector menu in the top left can be used to look at older versions of those notes. From the 4.2 version of those notes, support of Ubuntu 14.04 was dropped in 4.2.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the links! I've updated the comment to reflect that we test v2.6 and 3.X on Ubuntu 14.04.

.evergreen/config.yml
display_name: "MacOS 10.14"
run_on: macos-1014
variables:
GO_DIST: "/opt/golang/go1.15"
GO_DIST: "/opt/golang/go1.16"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I echo @benjirewis in waiting to run tasks on each changed platform before merging. macOS in particular is a special case, as it is not hosted through AWS, but instead with macstadium. We cannot spawn macOS hosts directly through evergreen. So investigating an issue with a macOS host is a little more work.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the latest patch build to run all of the macOS and Windows versions of the default PR Ubuntu tasks (which have all passed). Let me know if there's any other tasks I should run.

cc @benjirewis

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch LGTM!

@matthewdale matthewdale requested a review from benjirewis May 11, 2021 19:55
benjirewis
benjirewis approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@benjirewis benjirewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.evergreen/config.yml
display_name: "MacOS 10.14"
run_on: macos-1014
variables:
GO_DIST: "/opt/golang/go1.15"
GO_DIST: "/opt/golang/go1.16"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch LGTM!

@matthewdale matthewdale merged commit baa40c7 into mongodb:master May 11, 2021
stlimtat pushed a commit to stlimtat/mongo-go-driver that referenced this pull request May 17, 2021
Merge branch 'master' of https://github.com/mongodb/mongo-go-driver
461ed74 
* 'master' of https://github.com/mongodb/mongo-go-driver: (39 commits)
  GODRIVER-2004 Add Versioned API connection examples for Docs (mongodb#665)
  GODRIVER-1961 Run OCSP tests against RHEL 7.0 (mongodb#664)
  GODRIVER-1844 finer precision for getSecondsSinceEpoch (mongodb#666)
  GODRIVER-1973 create internal copy of aws v4 signing code (mongodb#657)
  GODRIVER-1951 Update the Go version for Evergreen builds to 1.16 (mongodb#663)
  GODRIVER-1949 add more ignored killAllSessions errors for unified tes… (mongodb#658)
  GODRIVER-1963 remove dropDatabase result (mongodb#660)
  GODRIVER-1180 Remove legacy transform functions from mongo (mongodb#583)
  GODRIVER-1937 Update legacy ListCollections to support the BatchSize option for server version 2.6 (mongodb#656)
  GODRIVER-1933 remove xtrace from shell scripts (mongodb#661)
  fix README error handling of FindOne (mongodb#636)
  GODRIVER-1938 update mongocryptd serverSelectionTimeout to 10 seconds (mongodb#659)
  GODRIVER-1925 Surface cursor errors in DownloadStream fillBuffer (mongodb#653)
  GODRIVER-1955 create labeledError interface (mongodb#651)
  GODRIVER-1947 Unmarshal unicode surrogate pairs correctly in UnmarshalExtJSON. (mongodb#649)
  Changed order of actions in ObjectIDFromHex func (mongodb#637)
  GODRIVER-1750 Ensure contexts are always cancelled during server monitoring (mongodb#654)
  GODRIVER-1931 Sync new cursors and SDAM LB tests (mongodb#655)
  GODRIVER-1981 Sync new transactions tests (mongodb#652)
  GODRIVER-1931 Run tests against LBs in Evergreen (mongodb#648)
  ...
@matthewdale matthewdale deleted the godriver1951-update-go-116 branch July 13, 2021 05:23
faem pushed a commit to kubedb/mongo-go-driver that referenced this pull request Mar 17, 2022
@matthewdale
GODRIVER-1951 Update the Go version for Evergreen builds to 1.16 (mon…
9d81784 
…godb#663)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinAlbs kevinAlbs kevinAlbs approved these changes

@benjirewis benjirewis benjirewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewdale @kevinAlbs @benjirewis