Bug 1596439 - Update dependencies for scriptworker 29.0.1 #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanLorenzo
changed the title
|
Hm, I wonder if the treescript requirement changes means we won’t install scriptworker at all? In which case we may need to add scriptworker back in, even if we don’t import it. |
rail
suggested changes
Nov 19, 2019
JohanLorenzo
force-pushed
the
sw-29.0.1
branch
from
52c7180 to
5e7e911
Compare
|
Great catch @escapewindow! I added |
|
I didn't think about it til I saw your diff :) Sorry I removed it. |
rail
approved these changes
Nov 19, 2019
| scriptworker==29.0.0 \ | ||
| --hash=sha256:32d06bedaa7f8134cdb6319ff4c1d044c03472ba3145b971989a52527858b274 \ | ||
| --hash=sha256:91f999f3eb60f7fd43b5e8df3f260ed79d277a930823a33de3618692d90ba89b | ||
| scriptworker==29.0.1 \ |
There was a problem hiding this comment.
Hm. I need 29.0.2 on treescript. (I just released that for https://bugzilla.mozilla.org/show_bug.cgi?id=1597671 ).
We can push your change, and then I can push my change to production-treescript, or we can push once with 29.0.2. I'm running pin.sh right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 notable things in addition to the regular bump:
importlib-metadatais not a dependency anymore becausejsonschemaremoved it for python 3.8+ Use importlib from stdlib (if possible) python-jsonschema/jsonschema#627. Thus,zippandmore-itertoolsare gone too.