Skip to content

Treescript 1.2.1 port to the monorepo #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 320 commits into from
Jul 26, 2019
Merged

Treescript 1.2.1 port to the monorepo #9

merged 320 commits into from
Jul 26, 2019

Conversation

escapewindow
Copy link
Contributor

This won't be the repository of record until we get taskcluster automation in the monorepo and can ship docker images to docker hub securely. However, this is a working treescript with retries, strip/purge, and l10n bumping, and includes all of https://github.com/mozilla-releng/treescript history.

Callek and others added 30 commits July 17, 2018 13:32
…2.1.0-to-14.0.0

Update scriptworker to 14.0.0
This reverts commit 61fedcb, reversing
changes made to f2f78cb.
Revert "Merge pull request #54 from srfraser/verification2"
require py37 tests to be green
…-4.2.0-to-4.3.0

Update more-itertools to 4.3.0
…o-3.7.1

Update pytest to 3.7.1 and pluggy to 0.7.1
…-0.8.0-to-0.9.0

Update pytest-asyncio to 0.9.0
…0.0-to-4.0.1

Update taskcluster to 4.0.1
@escapewindow escapewindow requested a review from Callek July 20, 2019 03:02
The main problem I'm hitting is that scriptworker_client isn't on pypi,
just a sibling sourcedir next to treescript. Therefore pip-compile can't
give me a hash, and pip install can't install hashes on everything but
one module.
Copy link
Contributor

@Callek Callek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I left a few inline comments on the csets that changed, none of them are blocking the merge though.

@@ -5,6 +5,10 @@
import treescript.l10n as l10n


async def noop_async(*args, **kwargs):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good fodder for a shared test module :-)

Copy link
Contributor Author

@escapewindow escapewindow Jul 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. The shared test module broke when i moved test/ out from under treescript/. I'm now debating whether we should move back.

(I suppose we could have a shared test module as a sibling to treescript that all *scripts tests can import..... hm... )

@escapewindow
Copy link
Contributor Author

Thanks!

@escapewindow escapewindow merged commit 6a42bf1 into mozilla-releng:master Jul 26, 2019
escapewindow added a commit that referenced this pull request Nov 18, 2019
* create dockerfile from base of repo instead of inside of script dir

* re-land changes from #9

* additional fixes to 6aca865

* pick up versionmanip changes from treescript repo

* update worker.yml for treestatus

* update changelog

* adjust schema

* don't require any scopes

* vendor robustcheckout.py from version-control-tools 4d4012c0a50f

* format robustcheckout with black, fix tests

* remove busted purge wrapper

* stop using mq
JohanLorenzo added a commit to JohanLorenzo/scriptworker-scripts that referenced this pull request Nov 19, 2019
JohanLorenzo added a commit to JohanLorenzo/scriptworker-scripts that referenced this pull request Nov 19, 2019
allan-silva pushed a commit to allan-silva/scriptworker-scripts that referenced this pull request Nov 19, 2019
* create dockerfile from base of repo instead of inside of script dir

* re-land changes from mozilla-releng#9

* additional fixes to 6aca865

* pick up versionmanip changes from treescript repo

* update worker.yml for treestatus

* update changelog

* adjust schema

* don't require any scopes

* vendor robustcheckout.py from version-control-tools 4d4012c0a50f

* format robustcheckout with black, fix tests

* remove busted purge wrapper

* stop using mq
@escapewindow escapewindow deleted the treescript branch March 13, 2020 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants