-
Notifications
You must be signed in to change notification settings - Fork 32
Treescript 1.2.1 port to the monorepo #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treescript 1.2.1 port to the monorepo #9
Conversation
…2.1.0-to-14.0.0 Update scriptworker to 14.0.0
dontbuild feature added
Revert "Merge pull request #54 from srfraser/verification2"
require py37 tests to be green
….1.3 Update tox to 3.1.3
…est-3.6.3-to-3.7.1
…-4.2.0-to-4.3.0 Update more-itertools to 4.3.0
…o-3.7.1 Update pytest to 3.7.1 and pluggy to 0.7.1
…-0.8.0-to-0.9.0 Update pytest-asyncio to 0.9.0
…0.0-to-4.0.1 Update taskcluster to 4.0.1
The main problem I'm hitting is that scriptworker_client isn't on pypi, just a sibling sourcedir next to treescript. Therefore pip-compile can't give me a hash, and pip install can't install hashes on everything but one module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, I left a few inline comments on the csets that changed, none of them are blocking the merge though.
@@ -5,6 +5,10 @@ | |||
import treescript.l10n as l10n | |||
|
|||
|
|||
async def noop_async(*args, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good fodder for a shared test module :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. The shared test module broke when i moved test/
out from under treescript/
. I'm now debating whether we should move back.
(I suppose we could have a shared test module as a sibling to treescript
that all *scripts tests can import..... hm... )
Thanks! |
* create dockerfile from base of repo instead of inside of script dir * re-land changes from #9 * additional fixes to 6aca865 * pick up versionmanip changes from treescript repo * update worker.yml for treestatus * update changelog * adjust schema * don't require any scopes * vendor robustcheckout.py from version-control-tools 4d4012c0a50f * format robustcheckout with black, fix tests * remove busted purge wrapper * stop using mq
* create dockerfile from base of repo instead of inside of script dir * re-land changes from mozilla-releng#9 * additional fixes to 6aca865 * pick up versionmanip changes from treescript repo * update worker.yml for treestatus * update changelog * adjust schema * don't require any scopes * vendor robustcheckout.py from version-control-tools 4d4012c0a50f * format robustcheckout with black, fix tests * remove busted purge wrapper * stop using mq
This won't be the repository of record until we get taskcluster automation in the monorepo and can ship docker images to docker hub securely. However, this is a working treescript with retries, strip/purge, and l10n bumping, and includes all of https://github.com/mozilla-releng/treescript history.