Update hlpdatabms4s.py

[peterohman]

Improved validation of reported data and reported id now independent of sw version

[mr-manuel]

Thanks for helping to improve the driver

[peterohman]

Isn't this code contradicting the comment?

# only read next data if the first one was successful, this saves time when checking multiple battery types
            result = result and self.get_settings()

This will always execute self.get_settings() even if the first one failed

[mr-manuel]

No, since it's the same as:

if result:
    result = self.get_settings()

only in a shorter form. The code is always elaborated from top to down and left to right. If there is a condition, the condition is only elaborated, if the result is not clear.

In the case result is true, then self.get_settings() is executed, since it could be false and both have to be true.

In the case result is false, then self.get_settings() is NOT executed, since it would not change the overall result.

[peterohman]

Right, I read "and" as a bitwise "and", but it is of course a logical "and"