Skip to content

Update hlpdatabms4s.py #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mr-manuel merged 2 commits into from
Oct 25, 2024
Merged

Update hlpdatabms4s.py #96

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c682af3
Update hlpdatabms4s.py
peterohman Oct 25, 2024
0a4a1f1
Update hlpdatabms4s.py
mr-manuel Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 42 additions & 22 deletions etc/dbus-serialbattery/bms/hlpdatabms4s.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,11 @@ def test_connection(self):
result = False
try:
# get settings to check if the data is valid and the connection is working
result = self.get_settings()
result = self.read_test_data()
# get the rest of the data to be sure, that all data is valid and the correct battery type is recognized
# only read next data if the first one was successful, this saves time when checking multiple battery types
result = result and self.read_test_data()
result = result and self.get_settings()
result = result and self.refresh_data()
except Exception:
(
exception_type,
Expand Down Expand Up @@ -67,8 +68,11 @@ def refresh_data(self):
pass
return result

def unique_identifier(self) -> str:
return "BMS4S_" + str(int(self.capacity))

def read_test_data(self):
test_data = self.read_serial_data_HLPdataBMS4S(b"pv\n", 0.2, 12)
test_data = self.read_serial_data_HLPdataBMS4S(b"pv\n", 0.3, 12)
if test_data is False:
return False
s1 = str(test_data)
Expand All @@ -79,12 +83,6 @@ def read_test_data(self):
self.poll_interval = 10000
self.control_discharge_current = 1000
self.control_charge_current = 1000
self.soc = 50
self.voltage = 13.2
self.current = 0
self.min_battery_voltage = 12.0
self.max_battery_voltage = 14.4

if self.cell_count is None:
self.cell_count = 4
for c in range(self.cell_count):
Expand All @@ -93,38 +91,58 @@ def read_test_data(self):
return False

def read_settings_data(self):
test_data = self.read_serial_data_HLPdataBMS4S(b"ps\n", 3, 700)
test_data = self.read_serial_data_HLPdataBMS4S(b"ps\n", 2.0, 700)
if test_data is False:
return False
s = str(test_data)
s = s.replace(",", ".")
par = get_par("BatterySize= ", s)
if par is False:
logger.error(">>> ERROR: BatterySize")
return False
self.capacity = int(par)
v = get_par("VoltHigh= ", s)
if v is False:
logger.error(">>> ERROR: VoltHigh")
return False
self.max_battery_voltage = float(v) * float(4)
v = get_par("VoltLow= ", s)
if v is False:
logger.error(">>> ERROR: VoltLow")
return False
self.min_battery_voltage = float(v) * float(4)

return True

def read_status_data(self):
status_data = self.read_serial_data_HLPdataBMS4S(b"m1\n", 0.2, 40)
if self.cell_count is None:
return False
status_data = self.read_serial_data_HLPdataBMS4S(b"m1\n", 0.3, 40)
if status_data is False:
return False
par1 = str(status_data)
par2 = str(status_data)
ix = par2.find("m1")
if ix == -1:
logger.error(">>> ERROR: m1 " + par1)
return False
par1 = par2[ix : len(par2)]
par = par1.split(",")
if len(par) < 8:
if len(par) < 13:
logger.error(">>> ERROR: <13 " + par1)
return False
if len(par[0]) < 7:
logger.error(">>> ERROR: <7 " + par1)
return False
p0 = str(par[0])
ix = p0.find(".")
if ix == -1:
logger.error(">>> ERROR: ix " + par1)
return False
if str(par[3]).find(".") == -1:
logger.error(">>> ERROR: par[3] " + par1)
return False
if str(par[11]).isdigit() is False:
logger.error(">>> ERROR: par[11] " + par1)
return False
par0 = p0[ix - 1 : len(p0)]

# v1,v2,v3,v4,current,soc,chargeoff,loadoff,vbat2,socnow,adj,beep,led,temp1,temp2...
Expand All @@ -137,10 +155,12 @@ def read_status_data(self):
self.cells[3].voltage = float(par[3])
self.current = float(par[4])
self.soc = int(par[5])
self.control_allow_charge = par[6]
self.charge_fet = par[6]
self.control_allow_discharge = par[7]
self.discharge_fet = par[7]
st = int(par[6]) == 1
self.control_allow_charge = st
self.charge_fet = st
st = int(par[7]) == 1
self.control_allow_discharge = st
self.discharge_fet = st

beep = int(par[11])
if beep == 2:
Expand All @@ -159,7 +179,6 @@ def read_status_data(self):
self.protection.high_voltage = 2
else:
self.protection.high_voltage = 0

if len(par) > 13:
nb = 0
min = int(1000)
Expand All @@ -170,19 +189,20 @@ def read_status_data(self):
ix += 1
if len(tmp) == 2:
name = tmp[0]
temp = int("".join(filter(str.isdigit, tmp[1])))
if name[0] == "b":
temp = int("".join(filter(str.isdigit, tmp[1])))
nb += 1
if temp > max:
max = temp
if temp < min:
min = temp
else:
logger.error(">>> ERROR: temp")
if nb == 1:
self.temp1 = max
if nb > 1:
self.temp1 = max
self.temp2 = min

return True

def manage_charge_voltage(self):
Expand All @@ -200,7 +220,7 @@ def read_serial_data_HLPdataBMS4S(self, command, time, min_len):

def read_serial_data(command, port, baud, time, min_len):
try:
with serial.Serial(port, baudrate=baud, timeout=0.5) as ser:
with serial.Serial(port, baudrate=baud, timeout=2.5) as ser:
ret = read_serialport_data(ser, command, time, min_len)
return ret

Expand Down