Skip to content

[styles] Add options definitions for makeStyles #13721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eps1lon merged 2 commits into from
Nov 28, 2018
Merged

[styles] Add options definitions for makeStyles #13721

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6b03de
[styles] Add options definitions for makeStyles
eps1lon Nov 28, 2018
f790cb1
[styles] Improve makeStyles typings test coverage
eps1lon Nov 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/material-ui-styles/src/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,12 @@ declare module '@material-ui/styles/makeStyles' {
ClassNameMap,
PropsOfStyles,
Styles,
WithStylesOptions,
} from '@material-ui/styles/withStyles';

export default function makeStyles<S extends Styles<any, any>>(
styles: S,
options?: WithStylesOptions<ClassKeyOfStyles<S>>,
): (props: PropsOfStyles<S>) => ClassNameMap<ClassKeyOfStyles<S>>;
}

Expand Down
3 changes: 3 additions & 0 deletions packages/material-ui-styles/test/index.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,9 @@ function testGetThemeProps(theme: Theme, props: AppBarProps): void {
</div>
);
};

// testing options
const useConfiguredStyles = makeStyles(styles, { flip: true, name: 'some-sheet' });
}

// styled
Expand Down