[styles] Add options definitions for makeStyles#13721
Merged
eps1lon merged 2 commits intomui:masterfrom Nov 28, 2018
Merged
Conversation
eps1lon
added
type: bug
eps1lon
force-pushed
the
fix/styles/makeStyles-options
branch
from
fe68a9e to
c6b03de
Compare
oliviertassinari
approved these changes
Nov 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13718.
@oliviertassinari I didn't test the
withThemeoption yet but I think that option is not needed for a hook. The option was previously used to inject the theme into the props. This is should now be done with auseThemehook.