Skip to content

making clickaway more logical#2346

Closed
chrismcv wants to merge 1 commit intomui:masterfrom
chrismcv:popover-layout
Closed

making clickaway more logical#2346
chrismcv wants to merge 1 commit intomui:masterfrom
chrismcv:popover-layout

Conversation

@chrismcv
Copy link
Copy Markdown
Contributor

@chrismcv chrismcv commented Dec 2, 2015

@oliviertassinari - this fixes your animation issue with nested menus

@oliviertassinari
Copy link
Copy Markdown
Member

I may have another approach to solve the issue.
I think that it would be better to add an onRequestClose property
to the Popover component to make it "controllable" as we are doing with the Dialog
or the LeftNav.
This approach would probably save us from using a ref.

@oliviertassinari
Copy link
Copy Markdown
Member

I think that it would be better to add an onRequestClose property

Edit: this property already exist and wasn't working as expected IMHO.
This is an attempt to improve it #2353.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: click away listener This is the name of the generic UI component, not the React module!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants