Skip to content

[Popover] Fix onRequestClose called 3 times#2353

Merged
oliviertassinari merged 2 commits intomui:masterfrom
oliviertassinari:popover-on-request-close
Dec 3, 2015
Merged

[Popover] Fix onRequestClose called 3 times#2353
oliviertassinari merged 2 commits intomui:masterfrom
oliviertassinari:popover-on-request-close

Conversation

@oliviertassinari
Copy link
Copy Markdown
Member

@chrismcv Could you review this PR. I think that It's also solving #2346

@chrismcv
Copy link
Copy Markdown
Contributor

chrismcv commented Dec 3, 2015

@oliviertassinari - this pretty much looks good. There is one case that we have with nested popovers that it doesn't support. Using a div layer in render-to-layer https://github.com/callemall/material-ui/pull/2346/files#diff-6adf2b35daa69784d26ee7e0f8289abbR64 sorts this - but it does require a prop closeOnClickAway to be passed through from the popover. Happy for you to merge this, and I can resubmit a PR for just render-to-layer.

@oliviertassinari
Copy link
Copy Markdown
Member Author

Thanks, I'm merging this one, and I'm waiting for your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: Popover The React component.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants