[card] Actionable card improvements#48105
Draft
silviuaavram wants to merge 7 commits intomui:masterfrom
Draft
Conversation
Netlify deploy previewBundle size report
|
mj12albert
reviewed
Mar 30, 2026
| }); | ||
|
|
||
| const { className, raised = false, ...other } = props; | ||
| const { className, raised = false, href, onClick, ...other } = props; |
Member
There was a problem hiding this comment.
Supporting both link (via href) and "button-like" (via implicit "onClick without href") creates annoying TS issues similar to what ButtonBase suffers, and makes it easy to create accessibility failures
Chip, like Card is also a thing that can be static, a link, or a clickable button(-like), I think we should align their APIs
What do you think about #48015 (comment)? @silviuaavram
Member
Author
There was a problem hiding this comment.
I agree about the V2 part, this way we avoid any confusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45130
A card's primary action is related to its main subject: the heading. The primary action is to expand the subject in the heading, either by navigating through a link, or executing an action. For this reason, Card accepts
hrefandonClick, which render the CardHead heading inside a link / button element. This element is focusable, and its focus style is reflected on the whole card. The card can also have other focusable elements in CardHeader, CardContent and CardActions. By default, CardActions, in this case, will render a visual indicating "Read more" element, but that could be customized or removed via slots.Accessibility:
https://www.youtube.com/watch?v=iIoHdxmC8eM&t=396s
https://inclusive-components.design/cards/#thepseudocontenttrick