-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
[card] Actionable card improvements #48105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
silviuaavram
wants to merge
7
commits into
mui:master
Choose a base branch
from
silviuaavram:feat/card-improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d3524f1
[card] Actionable card improvements
silviuaavram a2e01e3
add read more text
silviuaavram 82ffe81
add read more slot
silviuaavram 0f2797b
revert actionareacard
silviuaavram 91e0644
aria-description
silviuaavram 005a16b
demo instructions
silviuaavram fe8a966
prettier
silviuaavram File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| import * as React from 'react'; | ||
| import Card from '@mui/material/Card'; | ||
| import CardContent from '@mui/material/CardContent'; | ||
| import CardMedia from '@mui/material/CardMedia'; | ||
| import Typography from '@mui/material/Typography'; | ||
| import CardHeader from '@mui/material/CardHeader'; | ||
| import CardActions from '@mui/material/CardActions'; | ||
| import IconButton from '@mui/material/IconButton'; | ||
| import FavoriteIcon from '@mui/icons-material/Favorite'; | ||
| import ShareIcon from '@mui/icons-material/Share'; | ||
|
|
||
| export default function ActionableCard() { | ||
| return ( | ||
| <React.Fragment> | ||
| <Card href="#primary-action" sx={{ maxWidth: 345 }}> | ||
| <CardMedia | ||
| component="img" | ||
| height="140" | ||
| image="/static/images/cards/contemplative-reptile.jpg" | ||
| alt="green iguana" | ||
| /> | ||
| <CardHeader title="Lizard" /> | ||
| <CardContent> | ||
| <Typography variant="body2" sx={{ color: 'text.secondary' }}> | ||
| Lizards are a widespread group of squamate reptiles, with over 6,000 | ||
| species, ranging across all continents except Antarctica | ||
| </Typography> | ||
| </CardContent> | ||
| <CardActions> | ||
| <IconButton | ||
| aria-label="add to favorites" | ||
| onClick={() => alert('Favorite clicked')} | ||
| > | ||
| <FavoriteIcon /> | ||
| </IconButton> | ||
| <IconButton aria-label="share" onClick={() => alert('Share clicked')}> | ||
| <ShareIcon /> | ||
| </IconButton> | ||
| </CardActions> | ||
| </Card> | ||
| <Card onClick={() => alert('Card clicked')} sx={{ maxWidth: 345 }}> | ||
| <CardMedia | ||
| component="img" | ||
| height="140" | ||
| image="/static/images/cards/contemplative-reptile.jpg" | ||
| alt="green iguana" | ||
| /> | ||
| <CardHeader title="Lizard" /> | ||
| <CardContent> | ||
| <Typography variant="body2" sx={{ color: 'text.secondary' }}> | ||
| Lizards are a widespread group of squamate reptiles, with over 6,000 | ||
| species, ranging across all continents except Antarctica | ||
| </Typography> | ||
| </CardContent> | ||
| <CardActions> | ||
| <IconButton | ||
| aria-label="add to favorites" | ||
| onClick={() => alert('Favorite clicked')} | ||
| > | ||
| <FavoriteIcon /> | ||
| </IconButton> | ||
| <IconButton aria-label="share" onClick={() => alert('Share clicked')}> | ||
| <ShareIcon /> | ||
| </IconButton> | ||
| </CardActions> | ||
| </Card> | ||
| </React.Fragment> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| import * as React from 'react'; | ||
| import Card from '@mui/material/Card'; | ||
| import CardContent from '@mui/material/CardContent'; | ||
| import CardMedia from '@mui/material/CardMedia'; | ||
| import Typography from '@mui/material/Typography'; | ||
| import CardHeader from '@mui/material/CardHeader'; | ||
| import CardActions from '@mui/material/CardActions'; | ||
| import IconButton from '@mui/material/IconButton'; | ||
| import FavoriteIcon from '@mui/icons-material/Favorite'; | ||
| import ShareIcon from '@mui/icons-material/Share'; | ||
|
|
||
| export default function ActionableCard() { | ||
| return ( | ||
| <React.Fragment> | ||
| <Card href="#primary-action" sx={{ maxWidth: 345 }}> | ||
| <CardMedia | ||
| component="img" | ||
| height="140" | ||
| image="/static/images/cards/contemplative-reptile.jpg" | ||
| alt="green iguana" | ||
| /> | ||
| <CardHeader title="Lizard" /> | ||
| <CardContent> | ||
| <Typography variant="body2" sx={{ color: 'text.secondary' }}> | ||
| Lizards are a widespread group of squamate reptiles, with over 6,000 | ||
| species, ranging across all continents except Antarctica | ||
| </Typography> | ||
| </CardContent> | ||
| <CardActions> | ||
| <IconButton | ||
| aria-label="add to favorites" | ||
| onClick={() => alert('Favorite clicked')} | ||
| > | ||
| <FavoriteIcon /> | ||
| </IconButton> | ||
| <IconButton aria-label="share" onClick={() => alert('Share clicked')}> | ||
| <ShareIcon /> | ||
| </IconButton> | ||
| </CardActions> | ||
| </Card> | ||
| <Card onClick={() => alert('Card clicked')} sx={{ maxWidth: 345 }}> | ||
| <CardMedia | ||
| component="img" | ||
| height="140" | ||
| image="/static/images/cards/contemplative-reptile.jpg" | ||
| alt="green iguana" | ||
| /> | ||
| <CardHeader title="Lizard" /> | ||
| <CardContent> | ||
| <Typography variant="body2" sx={{ color: 'text.secondary' }}> | ||
| Lizards are a widespread group of squamate reptiles, with over 6,000 | ||
| species, ranging across all continents except Antarctica | ||
| </Typography> | ||
| </CardContent> | ||
| <CardActions> | ||
| <IconButton | ||
| aria-label="add to favorites" | ||
| onClick={() => alert('Favorite clicked')} | ||
| > | ||
| <FavoriteIcon /> | ||
| </IconButton> | ||
| <IconButton aria-label="share" onClick={() => alert('Share clicked')}> | ||
| <ShareIcon /> | ||
| </IconButton> | ||
| </CardActions> | ||
| </Card> | ||
| </React.Fragment> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| 'use client'; | ||
| import * as React from 'react'; | ||
|
|
||
| type CardContextValue = { | ||
| href?: string | undefined; | ||
| onClick?: React.MouseEventHandler<HTMLDivElement> | undefined; | ||
| }; | ||
|
|
||
| const CardContext = React.createContext<CardContextValue | null>(null); | ||
|
|
||
| const useCardContext = () => { | ||
| const context = React.useContext(CardContext); | ||
|
|
||
| if (context === null) { | ||
| throw new Error('useCardContext must be used within a Card'); | ||
| } | ||
| return context; | ||
| }; | ||
|
|
||
| const CardContextProvider = CardContext.Provider; | ||
|
|
||
| export { CardContextProvider, useCardContext }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supporting both link (via
href) and "button-like" (via implicit "onClick without href") creates annoying TS issues similar to what ButtonBase suffers, and makes it easy to create accessibility failuresChip, like Card is also a thing that can be static, a link, or a clickable button(-like), I think we should align their APIs
What do you think about #48015 (comment)? @silviuaavram
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree about the V2 part, this way we avoid any confusion.