Add .editorconfig to maintain consistent coding styles
#1517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harawata
requested changes
Apr 18, 2019
| indent_size = 2 | ||
| insert_final_newline = true | ||
| trim_trailing_whitespace = true | ||
| end_of_line = lf |
There was a problem hiding this comment.
Let's not add end_of_line. We have text=auto in .gitattributes.
| @@ -0,0 +1,12 @@ | |||
| root = true | |||
|
|
|||
| [*.{adoc, bat, groovy, html, java, js, jsp, kt, kts, md, properties, py, rb, sh, sql, svg, txt, vm, xml, xsd}] | |||
There was a problem hiding this comment.
[*.{java, xml, sql}] should be enough for our repo.
| [*.{adoc, bat, groovy, html, java, js, jsp, kt, kts, md, properties, py, rb, sh, sql, svg, txt, vm, xml, xsd}] | ||
| charset = utf-8 | ||
|
|
||
| [*.{groovy, java, kt, kts, vm, xml, xsd}] |
There was a problem hiding this comment.
Same as above. [*.{java, xml, sql}] should be enough.
There was a problem hiding this comment.
I agree with you! I just referred to Spring's .editorconfig file. It can be adjusted here. Thank you!
There was a problem hiding this comment.
Hi @ijliym I cannot edit the files. Maybe because you deleted the branch?
I'm not sure if it works, but can you restore the fork/branch?
There was a problem hiding this comment.
I'm very sorry, I don't know after delete this, there will be an impact. I've added it again now, but I don't think it might work. If it doesn't work, please trouble you add it yourself. I just want to have a .editorconfig file in the project, not necessarily if I add it.
Sorry again!
There was a problem hiding this comment.
GitHub does not recognize the new branch, but no worries.
Although it's a little bit irregular, I'll make the changes after merge. :)
Thanks for the contribution!
harawata
added a commit
to mybatis/spring
that referenced
this pull request
Apr 29, 2019
Changes requested on mybatis/mybatis-3#1517
George5814
pushed a commit
to George5814/mybatis-3
that referenced
this pull request
May 14, 2019
* master: (616 commits) Fix trivial grammer mistake Trivial doc correction Add 'defaultNetworkTimeout' to PooledDataSource and UnpooledDataSource Update README.md Follow-up to mybatis#1517 Change to use try-with-resources on doc New versions available. fixes mybatis#1523 Better error message when too many keys are generated Minor refactoring. Reuse PostgreSQL container without restarting Replace postgresql-embedded with Testcontainers Added Stack Overflow as a place for questions Add `.editorconfig` to maintain consistent coding styles [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release mybatis-3.5.1 [ci] Cache maven dependencies. Added edge case tests provided by @kdubb Add comment for derby Revert "Upgrade to derby 10.15.1.3" Upgrade to assertj 3.12.2 ... # Conflicts: # pom.xml # src/main/java/org/apache/ibatis/binding/MapperMethod.java # src/main/java/org/apache/ibatis/binding/MapperProxyFactory.java # src/main/java/org/apache/ibatis/binding/MapperRegistry.java # src/main/java/org/apache/ibatis/builder/annotation/MapperAnnotationBuilder.java # src/main/java/org/apache/ibatis/datasource/unpooled/UnpooledDataSource.java # src/main/java/org/apache/ibatis/plugin/Plugin.java # src/main/java/org/apache/ibatis/reflection/Reflector.java # src/main/java/org/apache/ibatis/session/Configuration.java # src/main/java/org/apache/ibatis/session/SqlSession.java # src/main/java/org/apache/ibatis/session/TransactionIsolationLevel.java # src/main/java/org/apache/ibatis/session/defaults/DefaultSqlSession.java # src/main/java/org/apache/ibatis/transaction/Transaction.java # src/main/java/org/apache/ibatis/transaction/TransactionFactory.java # src/main/java/org/apache/ibatis/transaction/jdbc/JdbcTransaction.java # src/main/java/org/apache/ibatis/transaction/managed/ManagedTransaction.java # src/main/java/org/apache/ibatis/type/ArrayTypeHandler.java # src/main/java/org/apache/ibatis/type/BaseTypeHandler.java # src/main/java/org/apache/ibatis/type/SimpleTypeRegistry.java # src/main/java/org/apache/ibatis/type/TypeAliasRegistry.java # src/main/java/org/apache/ibatis/type/TypeHandlerRegistry.java
pulllock
pushed a commit
to pulllock/mybatis-3
that referenced
this pull request
Oct 19, 2023
Add `.editorconfig` to maintain consistent coding styles
pulllock
pushed a commit
to pulllock/mybatis-3
that referenced
this pull request
Oct 19, 2023
pulllock
pushed a commit
to pulllock/mybatis-spring
that referenced
this pull request
Oct 19, 2023
Changes requested on mybatis/mybatis-3#1517
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See here for usage.