Skip to content

Add .editorconfig to maintain consistent coding styles #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harawata merged 1 commit into from
Apr 29, 2019
Merged

Add .editorconfig to maintain consistent coding styles #1517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
root = true

[*.{adoc, bat, groovy, html, java, js, jsp, kt, kts, md, properties, py, rb, sh, sql, svg, txt, vm, xml, xsd}]
Copy link
Member

@harawata harawata Apr 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[*.{java, xml, sql}] should be enough for our repo.

charset = utf-8

[*.{groovy, java, kt, kts, vm, xml, xsd}]
Copy link
Member

@harawata harawata Apr 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. [*.{java, xml, sql}] should be enough.

Copy link
Contributor Author

@ijliym ijliym Apr 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you! I just referred to Spring's .editorconfig file. It can be adjusted here. Thank you!

Copy link
Member

@harawata harawata Apr 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ijliym I cannot edit the files. Maybe because you deleted the branch?
I'm not sure if it works, but can you restore the fork/branch?

Copy link
Contributor Author

@ijliym ijliym Apr 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very sorry, I don't know after delete this, there will be an impact. I've added it again now, but I don't think it might work. If it doesn't work, please trouble you add it yourself. I just want to have a .editorconfig file in the project, not necessarily if I add it.
Sorry again!

Copy link
Member

@harawata harawata Apr 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub does not recognize the new branch, but no worries.
Although it's a little bit irregular, I'll make the changes after merge. :)
Thanks for the contribution!

Copy link
Contributor Author

@ijliym ijliym Apr 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're welcome.

indent_style = space
indent_size = 2
insert_final_newline = true
trim_trailing_whitespace = true
end_of_line = lf
Copy link
Member

@harawata harawata Apr 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not add end_of_line. We have text=auto in .gitattributes.