conf: validate integer suffix overflow#8194
Draft
immanuwell wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Immanuel Tikhonov <pchpr.00@list.ru>
immanuwell
force-pushed
the
fix-config-integer-suffix-validation
branch
from
7fcadcf to
7d6a96a
Compare
sciascid
reviewed
May 19, 2026
| const _EMPTY_ = "" | ||
|
|
||
| const ( | ||
| maxInt64 = int64(1<<63 - 1) |
Contributor
There was a problem hiding this comment.
Could use constants MaxInt64 and MinInt64 from the math package?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny config parser fix
Before, these passed config test, which is not it:
nats-server -t -c <file>reported both as valid on main. The first drops the value, the second wraps during suffix multiplication.Now invalid suffixes error, and oversized suffixed ints error too. Existing suffixes like
22GBstill work.Tests:
go test ./conf -count=1go test ./... -run TestNoSuchTest -count=1