Skip to content

conf: validate integer suffix overflow #8194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
immanuwell wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

conf: validate integer suffix overflow #8194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 24 additions & 13 deletions conf/parse.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,11 @@ import (

const _EMPTY_ = ""

const (
maxInt64 = int64(1<<63 - 1)

@sciascid sciascid May 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use constants MaxInt64 and MinInt64 from the math package?

minInt64 = -1 << 63
)

type parser struct {
mapping map[string]any
lx *lexer
Expand Down Expand Up @@ -318,34 +323,40 @@ func (p *parser) processItem(it item, fp string) error {
// Process a suffix
suffix := strings.ToLower(strings.TrimSpace(it.val[lastDigit:]))

multiplier := int64(1)
switch suffix {
case "":
setValue(it, num)
case "k":
setValue(it, num*1000)
multiplier = 1000
case "kb", "ki", "kib":
setValue(it, num*1024)
multiplier = 1024
case "m":
setValue(it, num*1000*1000)
multiplier = 1000 * 1000
case "mb", "mi", "mib":
setValue(it, num*1024*1024)
multiplier = 1024 * 1024
case "g":
setValue(it, num*1000*1000*1000)
multiplier = 1000 * 1000 * 1000
case "gb", "gi", "gib":
setValue(it, num*1024*1024*1024)
multiplier = 1024 * 1024 * 1024
case "t":
setValue(it, num*1000*1000*1000*1000)
multiplier = 1000 * 1000 * 1000 * 1000
case "tb", "ti", "tib":
setValue(it, num*1024*1024*1024*1024)
multiplier = 1024 * 1024 * 1024 * 1024
case "p":
setValue(it, num*1000*1000*1000*1000*1000)
multiplier = 1000 * 1000 * 1000 * 1000 * 1000
case "pb", "pi", "pib":
setValue(it, num*1024*1024*1024*1024*1024)
multiplier = 1024 * 1024 * 1024 * 1024 * 1024
case "e":
setValue(it, num*1000*1000*1000*1000*1000*1000)
multiplier = 1000 * 1000 * 1000 * 1000 * 1000 * 1000
case "eb", "ei", "eib":
setValue(it, num*1024*1024*1024*1024*1024*1024)
multiplier = 1024 * 1024 * 1024 * 1024 * 1024 * 1024
default:
return fmt.Errorf("invalid integer suffix '%s' in '%s'", suffix, it.val)
}
if multiplier > 1 && (num > maxInt64/multiplier || num < minInt64/multiplier) {
return fmt.Errorf("integer '%s' is out of the range", it.val)
}
setValue(it, num*multiplier)
case itemFloat:
num, err := strconv.ParseFloat(it.val, 64)
if err != nil {
Expand Down
16 changes: 16 additions & 0 deletions conf/parse_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,22 @@ func TestConvenientNumbers(t *testing.T) {
test(t, easynum, ex)
}

func TestConvenientNumbersInvalidSuffix(t *testing.T) {
if _, err := Parse("foo = 1kbb"); err == nil {
t.Fatal("Expected err for invalid number suffix")
} else if !strings.Contains(err.Error(), "invalid integer suffix") {
t.Fatalf("Expected invalid integer suffix error, got %q", err)
}
}

func TestConvenientNumbersOverflow(t *testing.T) {
if _, err := Parse("foo = 9223372036854775807k"); err == nil {
t.Fatal("Expected err for integer overflow")
} else if !strings.Contains(err.Error(), "out of the range") {
t.Fatalf("Expected out of range error, got %q", err)
}
}

func TestParseFileWithChecksDigestPreservesConfigKeyUsedAsVariable(t *testing.T) {
confFile := filepath.Join(t.TempDir(), "nats.conf")
if err := os.WriteFile(confFile, []byte(`
Expand Down
Loading