Add property-based testing to temporal-types conversion (#997) #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this type of testing to `.toString()` ('should be serialize string which can be loaded by new Date') helps to cover corner cases and solve special cases such:
* Negative date time not being serialised correctly in the iso standard. Years should always have 6 digits and the signal in front for working correctly with negative years and high numbers. This also avoids the year 2000 problem. See, https://en.wikipedia.org/wiki/ISO_8601
* `Date.fromStandardDate` factory was not taking in consideration the `seconds` contribution in the timezone offset. This is not a quite common scenario, but there are dates with timezone offset of for example `50 minutes` and `20 seconds`.
* Fix `Date.toString` for dates with offsets of seconds. Javascript Date constructor doesn't create dates from iso strings with seconds in the offset. For instance, `new Date("2010-01-12T14:44:53+00:00:10")`. So, this tests should be skipped.
|
Adapted cherry pick from: #997 |
robsdedude
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
While this is a breaking API change, it's also a fix. Not sure about the severity and if it's worth potentially breaking users.
Lastly, I checked the API documentation and that function isn't documented at all. So one could always argues it's fair game to break undocumented API, especially if it fixes things.
robsdedude
reviewed
Sep 21, 2022
Co-authored-by: Robsdedude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add this type of testing to
.toString()('should be serialize string which can be loaded by new Date') helps to cover corner cases and solve special cases such:Date.fromStandardDatefactory was not taking in consideration thesecondscontribution in the timezone offset. This is not a quite common scenario, but there are dates with timezone offset of for example50 minutesand20 seconds.Date.toStringfor dates with offsets of seconds. Javascript Date constructor doesn't create dates from iso strings with seconds in the offset. For instance,new Date("2010-01-12T14:44:53+00:00:10"). So, this tests should be skipped.