Update karma dependencies on neo4j-driver#1131
Merged
Conversation
This PR also fix some tests which are using done/async in a inconsistent way. This solves: https://github.com/neo4j/neo4j-javascript-driver/security/dependabot/107
robsdedude
approved these changes
Aug 17, 2023
Comment on lines
+276
to
+277
| it('should reset and flush when SUCCESS received', done => { | ||
| createConnection(`bolt://${sharedNeo4j.hostnameWithBoltPort}`).then(conn => { |
Member
There was a problem hiding this comment.
why is this one not async and using await?
Contributor
Author
There was a problem hiding this comment.
there is no await here. The async/await was removed from this test since we need to work with promises to be able to call resetAndFlush and simulate some protocol messages before the resolution of the promise. There are other tests doing something similar.
The mix of async/await with the callback done is not supported anymore in newer versions of karma, the is actually good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR also fix some tests which are using done/async in a inconsistent way.
This solves: https://github.com/neo4j/neo4j-javascript-driver/security/dependabot/107