Skip to content

Update karma dependencies on neo4j-driver #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Update karma dependencies on neo4j-driver #1131

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33da739
Update `karma` dependencies on `neo4j-driver`
bigmontz Aug 17, 2023
5d0caab
Address comments in the pr
bigmontz Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
153 changes: 54 additions & 99 deletions packages/neo4j-driver/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 5 additions & 7 deletions packages/neo4j-driver/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,16 +58,14 @@
"gulp-uglify": "^3.0.2",
"gulp-watch": "^5.0.1",
"jasmine-spec-reporter": "^7.0.0",
"karma": "^6.4.1",
"karma-chrome-launcher": "^3.1.1",
"karma-edge-launcher": "^0.4.2",
"karma": "^6.4.2",
"karma-chrome-launcher": "^3.2.0",
"karma-firefox-launcher": "^2.1.2",
"karma-ie-launcher": "^1.0.0",
"karma-jasmine": "^4.0.2",
"karma-jasmine": "^5.1.0",
"karma-source-map-support": "^1.4.0",
"karma-spec-reporter": "^0.0.36",
"karma-typescript": "^5.5.3",
"karma-typescript-es6-transform": "^5.5.3",
"karma-typescript": "^5.5.4",
"karma-typescript-es6-transform": "^5.5.4",
"lolex": "^6.0.0",
"minimist": "^1.2.8",
"rollup": "^2.77.4-1",
Expand Down
11 changes: 6 additions & 5 deletions packages/neo4j-driver/test/bolt-v3.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ describe('#integration Bolt V3 API', () => {
const result = await session.run(
'CALL dbms.listTransactions()',
{},
{ metadata: metadata }
{ metadata }
)
const receivedMetadatas = result.records.map(r => r.get('metaData'))
expect(receivedMetadatas).toContain(metadata)
Expand Down Expand Up @@ -184,7 +184,7 @@ describe('#integration Bolt V3 API', () => {
c: [1, 2, 3]
}

const tx = session.beginTransaction({ metadata: metadata })
const tx = session.beginTransaction({ metadata })

// call listTransactions procedure that should list itself with the specified metadata
const result = await tx.run('CALL dbms.listTransactions()')
Expand Down Expand Up @@ -218,7 +218,8 @@ describe('#integration Bolt V3 API', () => {
if (
e.code !== 'Neo.ClientError.Transaction.TransactionTimedOut' &&
e.code !== 'Neo.TransientError.Transaction.LockClientStopped' &&
e.code !== 'Neo.ClientError.Transaction.LockClientStopped'
e.code !== 'Neo.ClientError.Transaction.LockClientStopped' &&
e.code !== 'Neo.ClientError.Transaction.TransactionTimedOutClientConfiguration'
) {
fail('Expected transaction timeout error but got: ' + e.code)
}
Expand Down Expand Up @@ -461,8 +462,8 @@ describe('#integration Bolt V3 API', () => {

const txFunctionWithMetadata = work =>
read
? session.readTransaction(work, { metadata: metadata })
: session.writeTransaction(work, { metadata: metadata })
? session.readTransaction(work, { metadata })
: session.writeTransaction(work, { metadata })

const result = await txFunctionWithMetadata(tx =>
tx.run('CALL dbms.listTransactions()')
Expand Down
Loading