test: add integration tests for pattern sink handlers#120
Merged
ali-ince merged 17 commits intoneo4j:mainfrom Jun 10, 2024
ali-ince:test-pattern-strategies
Merged
test: add integration tests for pattern sink handlers#120ali-ince merged 17 commits intoneo4j:mainfrom ali-ince:test-pattern-strategies
ali-ince merged 17 commits intoneo4j:mainfrom
ali-ince:test-pattern-strategies
Conversation
fbiville
reviewed
May 27, 2024
sink-connector/src/test/kotlin/org/neo4j/connectors/kafka/sink/Neo4jNodePatternIT.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Emre Hizal <emre.hizal@neo4j.com>
fbiville
approved these changes
Jun 7, 2024
sink-connector/src/test/kotlin/org/neo4j/connectors/kafka/sink/Neo4jNodePatternIT.kt
Outdated
Show resolved
Hide resolved
sink-connector/src/test/kotlin/org/neo4j/connectors/kafka/sink/Neo4jNodePatternIT.kt
Outdated
Show resolved
Hide resolved
sink/src/main/kotlin/org/neo4j/connectors/kafka/sink/strategy/NodePatternHandler.kt
Show resolved
Hide resolved
venikkin
requested changes
Jun 7, 2024
|
|
||
| @Neo4jSink(nodePattern = [NodePatternStrategy(TOPIC, "(:User{!id})", false)]) | ||
| @Test | ||
| fun `should create and delete node in the same kafka transaction`( |
Contributor
There was a problem hiding this comment.
I'm afraid this test is not checking much. It's challenging to verify that nothing happened :) I think the eventual condition will kick in on the first attempt. I suspect you can comment out the publish and the test will still pass.
I can suggest inserting the user in some default condition before. In that case, the first message should be able to update it and the second will delete it.
Contributor
There was a problem hiding this comment.
I changed this to a test that only checks deletion of existing data in db.
venikkin
approved these changes
Jun 7, 2024
Contributor
venikkin
left a comment
venikkin
left a comment
There was a problem hiding this comment.
I think my suggestion from the previous review is minor, so approving here.
fbiville
approved these changes
Jun 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR;
Based on #116