refactor: re-implement cud strategy#127
Merged
ali-ince merged 13 commits intoneo4j:mainfrom Jun 11, 2024
ali-ince:refactor-cud-strategy
Merged
refactor: re-implement cud strategy#127ali-ince merged 13 commits intoneo4j:mainfrom ali-ince:refactor-cud-strategy
ali-ince merged 13 commits intoneo4j:mainfrom
ali-ince:refactor-cud-strategy
Conversation
ali-ince
changed the title
venikkin
approved these changes
Jun 7, 2024
| @TopicProducer(TOPIC) producer: ConvertingKafkaProducer, | ||
| session: Session | ||
| ) = runTest { | ||
| // session |
Contributor
There was a problem hiding this comment.
I guess this is left from a debug.
ali-ince
commented
Jun 7, 2024
Contributor
Author
ali-ince
left a comment
ali-ince
left a comment
There was a problem hiding this comment.
Looks good, added a few more suggestions for the tests.
sink-connector/src/test/kotlin/org/neo4j/connectors/kafka/sink/Neo4jCudIT.kt
Outdated
Show resolved
Hide resolved
sink-connector/src/test/kotlin/org/neo4j/connectors/kafka/sink/Neo4jCudIT.kt
Outdated
Show resolved
Hide resolved
sink-connector/src/test/kotlin/org/neo4j/connectors/kafka/sink/Neo4jCudIT.kt
Show resolved
Hide resolved
sink-connector/src/test/kotlin/org/neo4j/connectors/kafka/sink/Neo4jCudIT.kt
Outdated
Show resolved
Hide resolved
sink-connector/src/test/kotlin/org/neo4j/connectors/kafka/sink/Neo4jCudIT.kt
Show resolved
Hide resolved
sink-connector/src/test/kotlin/org/neo4j/connectors/kafka/sink/Neo4jCudIT.kt
Show resolved
Hide resolved
ali-ince
commented
Jun 11, 2024
sink-connector/src/test/kotlin/org/neo4j/connectors/kafka/sink/Neo4jCudIT.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR;
Based on #120